1339919 - Clicking the "New Tab" icon from the widget should always show the newly opened tab

Status: RESOLVED DUPLICATE of bug 1350994

(Firefox for Android Graveyard :: General, defect)

Description

[Kaartic Sivaraam]

Currently the widget has the "New tab" icon which should open the browser and create the new tab. In some cases the newly created tab is not shown as the current tab when the browser is opened.


Note : Widget must be present in the home screen before proceeding

Steps to reproduce :
1. Open the browser and click the Tab icon and click the home button
2. Tap the "New tab" button in the home screen widget

Expected results : 
The newly opened tab is shown as the current tab

Actual results :
The list of tabs is shown

Comment 2

[Kaartic Sivaraam]

Sorry but this is not a duplicate of that bug. I should have been clear in the description, sorry about that. The correced version of the Actual results,

The list of tabs is shown including the newly created one.

I actually filed this bug as I thought it would be better to show the newly opened tab instead of the tabs list in this case.

Comment 3

[friedger]

This bug (not closing the list of tabs) is also true for any other new intent (i.e. firefox is running and another app launching firefox)

Comment 4

[friedger]

Attachment: Bug 1339919 - Clicking the "New Tab" icon from the widget should always show the newly opened tab

Add check for open tabs panel when opening url from external app

Review commit: https://reviewboard.mozilla.org/r/135052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135052/

Comment 5

[Jan Henning [:JanH]]

Maybe the simple patch is right, but bug 1350994 has some discussion on people possible edge cases to consider.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Comment on attachment 8863268 [details]
Bug 1339919 - Clicking the "New Tab" icon from the widget should always show the newly opened tab

Putting a patch on a duplicate bug will cause this patch to be missed. Place your patch on bug 1350994. 

I am not a code reviewer. Please ask Sebastian Kaspari or JanH for review.