1339945 - Refactor mscom::MainThreadInvoker

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I want to move the waiting mechanism into a separate class.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1339945: Refactor mscom::MainThreadInvoker's wait mechanism into a separate class;

Review commit: https://reviewboard.mozilla.org/r/112798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112798/

Comment 2

[David Parks [:handyman]]

Comment on attachment 8837793 [details]
Bug 1339945: Refactor mscom::MainThreadInvoker's wait mechanism into a separate class;

https://reviewboard.mozilla.org/r/112798/#review117196

::: ipc/mscom/MainThreadInvoker.cpp:38
(Diff revision 1)
>    {
> -    MOZ_ASSERT(sIsMulticore || mDoneEvent);
>      MOZ_ASSERT(mRunnable);
>    }
>  
> -  ~SyncRunnable()
> +  ~SyncRunnable() = default;

Its up to you but do you feel we still need this?  Same for ~SpinEvent.

::: ipc/mscom/SpinEvent.cpp:30
(Diff revision 1)
> +namespace mscom {
> +
> +SpinEvent::SpinEvent()
> +  : mDone(false)
> +{
> +  static const bool sIsMulticore = []() {

Points for the first time I've seen this pattern used for a static init block in C++.  I'll have to remember that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ae0446f58c3
Refactor mscom::MainThreadInvoker's wait mechanism into a separate class; r=handyman

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ae0446f58c3