1339961 - Media panel web extension requires access to debuginfo of media elements on page

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Karolien]

I am converting this add-on: https://github.com/jyavenard/aboutmedia to a web extension and some of the media element information (HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo()) is hidden behind chrome privileges. Since chrome privileges are not going to be given to web extensions, based on advice from aswan, I am adding a check for 'debugger' permission in web extensions manifest.json file. Although this permission is not yet officially supported in Firefox, it is used in Chrome.

Comment 1

[Karolien]

Attachment: Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo().

Review commit: https://reviewboard.mozilla.org/r/112816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112816/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8837827 [details]
Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo().

https://reviewboard.mozilla.org/r/112816/#review114360

r+ for the .webidl, assuming HasDebuggerPrivilege works. However I'm not at all familiar with web extensions permission model, so someone else must look at that part.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8837827 [details]
Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo().

https://reviewboard.mozilla.org/r/112816/#review114378

I'm fine with the changes to HTMLMediaElement.h and .cpp

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/569c46670744
Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo(). r=kentuckyfriedtakahe,smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/569c46670744