Closed Bug 1339961 Opened 4 years ago Closed 4 years ago

Media panel web extension requires access to debuginfo of media elements on page

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kkoorts, Assigned: kkoorts)

References

Details

Attachments

(1 file)

I am converting this add-on: https://github.com/jyavenard/aboutmedia to a web extension and some of the media element information (HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo()) is hidden behind chrome privileges. Since chrome privileges are not going to be given to web extensions, based on advice from aswan, I am adding a check for 'debugger' permission in web extensions manifest.json file. Although this permission is not yet officially supported in Firefox, it is used in Chrome.
Assignee: nobody → kkoorts
Comment on attachment 8837827 [details]
Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo().

https://reviewboard.mozilla.org/r/112816/#review114360

r+ for the .webidl, assuming HasDebuggerPrivilege works. However I'm not at all familiar with web extensions permission model, so someone else must look at that part.
Attachment #8837827 - Flags: review?(bugs) → review+
Comment on attachment 8837827 [details]
Bug 1339961 - Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo().

https://reviewboard.mozilla.org/r/112816/#review114378

I'm fine with the changes to HTMLMediaElement.h and .cpp
Attachment #8837827 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/569c46670744
Check for 'debugger' privilege when accessing HTMLMediaElement.mozMediaSourceObject, mozDebugReaderData, mozRequestDebugInfo(). r=kentuckyfriedtakahe,smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/569c46670744
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.