1340023 - Mexico Holidays 2017-2020

Status: RESOLVED INCOMPLETE

(Calendar :: Website, enhancement)

Description

[lasr21]

Attachment: MexicoHolidays.ics

Mexican official holidays for 2017-2020

Comment 1

[[:MakeMyDay]]

Thanks for providing a file for the Mexican calendar.

Is this a copy of an officially provided Google holiday calendar or handcrafted by you using a Google account?

If the former, this would not be appropriate. If the latter, at least remove the METHOD property and adjust the PRODID to the standard Mozilla id (you would get this when exporting a calendar from Lightning).

Comment 2

[lasr21]

Attachment: MexicoHolidays.ics

thanks for the feedback, indeed  was handcrafted using Google Calendar. 

I remade it using lighting hope this time is correct.

Comment 3

[[:MakeMyDay]]

Comment on attachment 8841836 [details]
MexicoHolidays.ics

Thanks for your contribution. If you are requesting review, please make sure to request it from somebody specifically, otherwise your request may be idling forever. There's also a functionallity to get prometed with a suggested reviewer when uploading the attachment.

Regarding your calendar file, please remove the timezone reference from the DTSTART/DTEND like for all the other events, make these date only values and subsequently also remove the initial timezone definition and upload an updated file:

BEGIN:VEVENT
CREATED:20170228T020606Z
LAST-MODIFIED:20170228T020615Z
DTSTAMP:20170228T020615Z
UID:7e0efebd-1565-3440-b6dd-f8abe5971074
SUMMARY:Día de la constitución Mexicana
CATEGORIES:Public Holiday
DTSTART;TZID=America/Mexico_City:20200203T210000
DTEND;TZID=America/Mexico_City:20200203T220000
TRANSP:OPAQUE
END:VEVENT

Comment 4

[Martin Schröder [:mschroeder]]

Resolving as INCOMPLETE as there was no response to comment#3 from the reporter. Feel free to reopen if an updated calendar can be provided or open a pull request at https://github.com/thundernest/thunderbird-website.