1340031 - vcssync: UnicodeDecodeError during overlay

Status: RESOLVED FIXED

(Developer Services :: Servo VCS Sync, defect)

Description

[:glob ✱]

Attachment: failure log

> 343187:509938eace0a: servo: Merge #15549 - Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, syn, & others (from mbrubeck:always-be-updating); r=jdm
> abort: 'ascii' codec can't decode byte 0xe2 in position 44: ordinal not in range(128)

Comment 1

[:glob ✱]

changeset:   8356:80b727552773
user:        Simon Sapin <[e-mail]>
date:        Tue Feb 14 16:07:10 2017 -0800
summary:     servo: Merge #15555 - tidy: Ignore [replace]’d packages in the duplicate package lint (from servo:tidy-ignore-replace); r=nox

it's that pesky smart quote.

Comment 2

[:glob ✱]

Attachment: vcssync: expose overlay-hg-repos cli to tests (bug 1340031)

overlay-hg-repos wasn't callable from tests, causing failures.

Review commit: https://reviewboard.mozilla.org/r/112944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112944/

Comment 3

[:glob ✱]

Attachment: vcssync: fix unicode handling in cli (bug 1340031);

Review commit: https://reviewboard.mozilla.org/r/112946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112946/

Comment 4

[:glob ✱]

Comment on attachment 8837944 [details]
vcssync: expose overlay-hg-repos cli to tests (bug 1340031)

https://reviewboard.mozilla.org/r/112944/#review114502

::: vcssync/tests/helpers.sh:7
(Diff revision 1)
> +# create overlay-hg-repos cli
> +cat > $TESTTMP/overlay-hg-repos <<EOF
> +#!$TESTDIR/venv/bin/python
> +import sys
> +from mozvcssync.cli import overlay_hg_repos_cli
> +sys.exit(overlay_hg_repos_cli())
> +EOF
> +chmod +x $TESTTMP/overlay-hg-repos
> +alias overlay-hg-repos=$TESTTMP/overlay-hg-repos
> +

now that i've had time to think, i bet this isn't needed if i rebuild my environment.  will investigate and provide an updated patch.

this won't impact the actual fix and testcase in the other commit.

Comment 5

[:glob ✱]

Comment on attachment 8837944 [details]
vcssync: expose overlay-hg-repos cli to tests (bug 1340031)

https://reviewboard.mozilla.org/r/112944/#review114502

> now that i've had time to think, i bet this isn't needed if i rebuild my environment.  will investigate and provide an updated patch.
> 
> this won't impact the actual fix and testcase in the other commit.

this is indeed the case.

Comment 6

[:glob ✱]

Comment on attachment 8837945 [details]
vcssync: fix unicode handling in cli (bug 1340031);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/112946/diff/1-2/

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8837945 [details]
vcssync: fix unicode handling in cli (bug 1340031);

https://reviewboard.mozilla.org/r/112946/#review114550

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a1bcb37bb683
vcssync: fix unicode handling in cli ; r=smacleod