vcssync: UnicodeDecodeError during overlay

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Created attachment 8837921 [details]
failure log

> 343187:509938eace0a: servo: Merge #15549 - Update aho-corasick, backtrace-sys, image, parking_lot, pdqsort, syn, & others (from mbrubeck:always-be-updating); r=jdm
> abort: 'ascii' codec can't decode byte 0xe2 in position 44: ordinal not in range(128)
(Assignee)

Comment 1

2 years ago
changeset:   8356:80b727552773
user:        Simon Sapin <simon.sapin@exyr.org>
date:        Tue Feb 14 16:07:10 2017 -0800
summary:     servo: Merge #15555 - tidy: Ignore [replace]’d packages in the duplicate package lint (from servo:tidy-ignore-replace); r=nox

it's that pesky smart quote.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8837944 [details]
vcssync: expose overlay-hg-repos cli to tests (bug 1340031)

https://reviewboard.mozilla.org/r/112944/#review114502

::: vcssync/tests/helpers.sh:7
(Diff revision 1)
> +# create overlay-hg-repos cli
> +cat > $TESTTMP/overlay-hg-repos <<EOF
> +#!$TESTDIR/venv/bin/python
> +import sys
> +from mozvcssync.cli import overlay_hg_repos_cli
> +sys.exit(overlay_hg_repos_cli())
> +EOF
> +chmod +x $TESTTMP/overlay-hg-repos
> +alias overlay-hg-repos=$TESTTMP/overlay-hg-repos
> +

now that i've had time to think, i bet this isn't needed if i rebuild my environment.  will investigate and provide an updated patch.

this won't impact the actual fix and testcase in the other commit.
(Assignee)

Comment 5

2 years ago
mozreview-review-reply
Comment on attachment 8837944 [details]
vcssync: expose overlay-hg-repos cli to tests (bug 1340031)

https://reviewboard.mozilla.org/r/112944/#review114502

> now that i've had time to think, i bet this isn't needed if i rebuild my environment.  will investigate and provide an updated patch.
> 
> this won't impact the actual fix and testcase in the other commit.

this is indeed the case.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8837944 - Attachment is obsolete: true
Attachment #8837944 - Flags: review?(smacleod)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8837945 [details]
vcssync: fix unicode handling in cli (bug 1340031);

https://reviewboard.mozilla.org/r/112946/#review114550
Attachment #8837945 - Flags: review?(smacleod) → review+

Comment 8

2 years ago
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a1bcb37bb683
vcssync: fix unicode handling in cli ; r=smacleod
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Component: General → Servo VCS Sync
You need to log in before you can comment on or make changes to this bug.