Closed Bug 1340044 Opened 3 years ago Closed 3 years ago

Change the type of nsStyleDisplay::mTransformBox from uint_8 to StyleGeometryBox.

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: u459114, Assigned: u459114)

References

Details

Attachments

(2 files)

Split from bug 1335876 so that we can land the other patches in that bug independent of stylo change
Assignee: nobody → cku
Attachment #8837932 - Flags: review?(cam)
Comment on attachment 8837932 [details]
Bug 1340044 - Part 1. Declare mTransformBox as StyleGeometryBox.

https://reviewboard.mozilla.org/r/112924/#review122310

::: layout/style/nsStyleConsts.h:147
(Diff revision 2)
> +// shape-box for shape-outside
> +enum class StyleShapeOutsideShapeBox : uint8_t {
> +  NoBox,
> +  Content,
> +  Padding,
> +  Border,
> +  Margin
> +};
> +

Is this used anywhere?
Attachment #8837932 - Flags: review?(cam) → review+
Comment on attachment 8837932 [details]
Bug 1340044 - Part 1. Declare mTransformBox as StyleGeometryBox.

https://reviewboard.mozilla.org/r/112924/#review122310

> Is this used anywhere?

something wrond while merging, fixed.
Attachment #8847941 - Flags: review?(cam)
Comment on attachment 8847941 [details]
Bug 1340044 - Part 2. Rename value in StyleGeometryBox.

https://reviewboard.mozilla.org/r/120876/#review122842

::: layout/painting/nsCSSRendering.cpp:2021
(Diff revision 1)
>  }
>  
>  static bool
>  IsSVGStyleGeometryBox(StyleGeometryBox aBox)
>  {
> -  return (aBox == StyleGeometryBox::Fill || aBox == StyleGeometryBox::Stroke ||
> +  return (aBox == StyleGeometryBox::FillBox |

||
Attachment #8847941 - Flags: review?(cam) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/248f3609df08
Part 1. Declare mTransformBox as StyleGeometryBox. r=heycam
https://hg.mozilla.org/integration/autoland/rev/f86b20231a00
Part 2. Rename value in StyleGeometryBox. r=heycam
https://hg.mozilla.org/mozilla-central/rev/248f3609df08
https://hg.mozilla.org/mozilla-central/rev/f86b20231a00
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.