Closed Bug 1340061 Opened 3 years ago Closed 3 years ago

Remove explicit base URI facility

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(2 files)

There is currently only one use of explicit base URI function, which is for anonymous content inside SVG <use> element.

The requirement of <use> element can be handled more efficiently than this general mechanism. Thus we should remove this.
Summary: Remove explicit base URI → Remove explicit base URI facility
Priority: -- → P3
Assignee: nobody → xidorn+moz
bz, are you find with reviewing the two patches? Or could you recommend someone I can ask for reviewing them?
Flags: needinfo?(bzbarsky)
are you *fine with...
Comment on attachment 8838394 [details]
Bug 1340061 part 1 - Use source doc URI for SVG <use> anonymous content.

https://reviewboard.mozilla.org/r/113332/#review115026
Attachment #8838394 - Flags: review+
Comment on attachment 8838395 [details]
Bug 1340061 part 2 - Remove explicit base URI facility.

https://reviewboard.mozilla.org/r/113334/#review115024

::: dom/base/nsINode.h
(Diff revision 1)
>      // Maybe set if this node is in black subtree.
>      NodeIsCCBlackTree,
>      // Maybe set if the node is a root of a subtree
>      // which needs to be kept in the purple buffer.
>      NodeIsPurpleRoot,
> -    // Set if the node has an explicit base URI stored

You're going to have to merge to this flag no longer existing, but that's probably OK.
Attachment #8838395 - Flags: review+
Flags: needinfo?(bzbarsky)
(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #6)
> You're going to have to merge to this flag no longer existing, but that's
> probably OK.

I don't quite get what do you mean here. Are you concerned about that there would be some merge conflict happens at some point? Is there any bug in your mind which could conflict with it?
Flags: needinfo?(bzbarsky)
https://hg.mozilla.org/mozilla-central/rev/2e4af18d8ed6 is the conflicting diff I was thinking of.
Flags: needinfo?(bzbarsky)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8a4718430f2
part 1 - Use source doc URI for SVG <use> anonymous content. r=bz
https://hg.mozilla.org/integration/autoland/rev/93b2e63886f4
part 2 - Remove explicit base URI facility. r=bz
https://hg.mozilla.org/mozilla-central/rev/f8a4718430f2
https://hg.mozilla.org/mozilla-central/rev/93b2e63886f4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.