Closed
Bug 1340061
Opened 7 years ago
Closed 7 years ago
Remove explicit base URI facility
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(2 files)
There is currently only one use of explicit base URI function, which is for anonymous content inside SVG <use> element. The requirement of <use> element can be handled more efficiently than this general mechanism. Thus we should remove this.
Assignee | ||
Updated•7 years ago
|
Summary: Remove explicit base URI → Remove explicit base URI facility
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
bz, are you find with reviewing the two patches? Or could you recommend someone I can ask for reviewing them?
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 4•7 years ago
|
||
are you *fine with...
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8838394 [details] Bug 1340061 part 1 - Use source doc URI for SVG <use> anonymous content. https://reviewboard.mozilla.org/r/113332/#review115026
Attachment #8838394 -
Flags: review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8838395 [details] Bug 1340061 part 2 - Remove explicit base URI facility. https://reviewboard.mozilla.org/r/113334/#review115024 ::: dom/base/nsINode.h (Diff revision 1) > // Maybe set if this node is in black subtree. > NodeIsCCBlackTree, > // Maybe set if the node is a root of a subtree > // which needs to be kept in the purple buffer. > NodeIsPurpleRoot, > - // Set if the node has an explicit base URI stored You're going to have to merge to this flag no longer existing, but that's probably OK.
Attachment #8838395 -
Flags: review+
Updated•7 years ago
|
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #6) > You're going to have to merge to this flag no longer existing, but that's > probably OK. I don't quite get what do you mean here. Are you concerned about that there would be some merge conflict happens at some point? Is there any bug in your mind which could conflict with it?
Flags: needinfo?(bzbarsky)
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e4af18d8ed6 is the conflicting diff I was thinking of.
Flags: needinfo?(bzbarsky)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8a4718430f2 part 1 - Use source doc URI for SVG <use> anonymous content. r=bz https://hg.mozilla.org/integration/autoland/rev/93b2e63886f4 part 2 - Remove explicit base URI facility. r=bz
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f8a4718430f2 https://hg.mozilla.org/mozilla-central/rev/93b2e63886f4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•