Closed Bug 1340096 Opened 7 years ago Closed 7 years ago

Remove MediaCodecDataDecoder

Categories

(Core :: Audio/Video: Playback, defect)

Unspecified
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jya, Unassigned)

Details

Attachments

(1 file)

We now have the RemoteDataDecoder which is turned on by default.

Maintaining MediaCodecDataDecoder takes unnecessary; it has lived a long life, time to put it to rest now.
Comment on attachment 8838008 [details]
Bug 1340096: Remove MediaCodecDataDecoder.

https://reviewboard.mozilla.org/r/113010/#review114794

LGTM. You are moving so fast!
Attachment #8838008 - Flags: review?(bwu) → review+
Attachment #8838008 - Flags: review?(jolin)
Comment on attachment 8838008 [details]
Bug 1340096: Remove MediaCodecDataDecoder.

https://reviewboard.mozilla.org/r/113010/#review114798

Looks good to me. Let's bury `LocalMediaDrmBridge` with it.

::: mobile/android/base/java/org/mozilla/gecko/media/MediaDrmProxy.java
(Diff revision 1)
> -            if (isRemote) {
> -                IMediaDrmBridge remoteBridge =
> +            IMediaDrmBridge remoteBridge =
> -                    RemoteManager.getInstance().createRemoteMediaDrmBridge(keySystem, mDrmStubId);
> +                RemoteManager.getInstance().createRemoteMediaDrmBridge(keySystem, mDrmStubId);
> -                mImpl = new RemoteMediaDrmBridge(remoteBridge);
> +            mImpl = new RemoteMediaDrmBridge(remoteBridge);
> -            } else {
> -                mImpl = new LocalMediaDrmBridge(keySystem);

Looks like the Java class `LocalMediaDrmBridge` is no longer in use and can be removed too.
Attachment #8838008 - Flags: review?(jolin) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4d9e53bfd68
Remove MediaCodecDataDecoder. r=bwu,jolin
https://hg.mozilla.org/mozilla-central/rev/c4d9e53bfd68
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
I really wish we would've left this in the tree for now. We haven't even shipped the remote decoder yet. I can definitely see us hitting problems with video on beta, and this leaves us with a more complicated path to getting back to a known-good state.
I truly understand your concern. But since there are too many libstagefright crashes, we need to ship remote decoder/OOP decoding quicker and make it much stabler.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: