Hide the result without primary label in ProfileAutoCompleteResult

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Form Manager
P3
enhancement
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: seanlee, Assigned: seanlee)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [form autofill:M1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
The result without primary label should not be returned by ProfileAutoCompleteResult.
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Assignee: nobody → selee
Comment on attachment 8838067 [details]
Bug 1340104 - Hide the result without primary label in ProfileAutoCompleteResult.;

https://reviewboard.mozilla.org/r/113070/#review115820

Thanks

::: browser/extensions/formautofill/ProfileAutoCompleteResult.jsm:126
(Diff revision 1)
>  
>      return ""; // Nothing matched.
>    },
>  
>    _generateLabels(focusedFieldName, allFieldNames, profiles) {
> -    return profiles.map(profile => {
> +    // Skip the result without the primary label.

Nit: s/Skip the result without the/Skip results without a/
Attachment #8838067 - Flags: review?(MattN+bmo) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

6 months ago
Hey MattN, The comment is updated, thanks!
Keywords: checkin-needed

Comment 5

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1d16150ba521
Hide the result without primary label in ProfileAutoCompleteResult.; r=MattN
Keywords: checkin-needed

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d16150ba521
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
As per San-Francisco meeting with :vchen, marking this bug as qe-.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.