Closed Bug 1340104 Opened 7 years ago Closed 7 years ago

Hide the result without primary label in ProfileAutoCompleteResult

Categories

(Toolkit :: Form Manager, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: selee, Assigned: selee)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:M1])

Attachments

(1 file)

The result without primary label should not be returned by ProfileAutoCompleteResult.
Assignee: nobody → selee
Comment on attachment 8838067 [details]
Bug 1340104 - Hide the result without primary label in ProfileAutoCompleteResult.;

https://reviewboard.mozilla.org/r/113070/#review115820

Thanks

::: browser/extensions/formautofill/ProfileAutoCompleteResult.jsm:126
(Diff revision 1)
>  
>      return ""; // Nothing matched.
>    },
>  
>    _generateLabels(focusedFieldName, allFieldNames, profiles) {
> -    return profiles.map(profile => {
> +    // Skip the result without the primary label.

Nit: s/Skip the result without the/Skip results without a/
Attachment #8838067 - Flags: review?(MattN+bmo) → review+
Hey MattN, The comment is updated, thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1d16150ba521
Hide the result without primary label in ProfileAutoCompleteResult.; r=MattN
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1d16150ba521
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
As per San-Francisco meeting with :vchen, marking this bug as qe-.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.