Stop using --max-requests with gunicorn now datasource isn't leaking

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1312007 found datasource was leaking, which is why we had had to use the `--max-requests 150` option for gunicorn in bug 1307785.

Now that we're no longer using datasource, we should try removing `--max-requests` entirely, which should increase the performance of our web dynos, since they are not constantly restarting gunicorn worker threads.

If that shows us to still have small leaks we could always still use it but at a much higher number of requests.
Created attachment 8838015 [details] [review]
[treeherder] mozilla:gunicorn-no-max-requests > mozilla:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8838015 [details] [review]
[treeherder] mozilla:gunicorn-no-max-requests > mozilla:master

This is being tested on prod now (load too low on stage to be useful), and looks fine so far:
https://dashboard.heroku.com/apps/treeherder-prod/metrics/web?starting=2-hours-ago
Attachment #8838015 - Flags: review?(wlachance)
(Assignee)

Updated

2 years ago
Blocks: 1059325
Attachment #8838015 - Flags: review?(wlachance) → review+

Comment 3

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6502ec24b1b31a2cd42a6fea5aeb27243367ff12
Bug 1340123 - Stop using --max-requests with gunicorn

Since hopefully now we're no longer using datasource, the leaks should
have gone. The gunicorn processes will now only be restarted at the
daily Heroku dyno restart, rather than multiple times per minute,
improving performance.
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.