1340130 - Skip the content initialization for DrawTarget if the content will be replaced soon

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

In [1], we create a DrawTarget and copy another surface on it. In this case, we don't need to have the initial value for that DrawTarget.

This bug try to create a new api CreateSimilarDrawTargetWithSurfaceData(), and skip the initial operation if possible.

[1]
https://hg.mozilla.org/mozilla-central/annotate/51377a64158941f89ed73f388ae437cfa494c030/dom/canvas/CanvasRenderingContext2D.cpp#l4372

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: create a DrawTarget with the existing Surface data.

MozReview-Commit-ID: KCWemfPo14A

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: DrawTargetD2D1::CreateSimilarDrawTargetWithSurfaceData() impl.

MozReview-Commit-ID: CLdYEo1HDzC

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Do we have an example case where this speeds things up?  It'd be good to track the improvement.

Comment 4

[Bas Schouten (:bas.schouten)]

Unless we get an answer to Milan's question I'm going to unflag these patches for review? I'm willing to believe this is a good change for sure, but I'd like to see some data backing it up.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bhood, could you have a look please?
For more information, please visit auto_nag documentation.