[PATCH] long anchor text in jprof output causes horizontal jumping

RESOLVED FIXED in Future

Status

()

Core
Layout
P3
enhancement
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Dave Morrison, Assigned: Dave Morrison)

Tracking

Trunk
Future
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
Many of the symbol names in jprof output are very long.  When these are used as
the text for HTML anchors, it results in very long link names.  As you click on
one link after another, the page scrolls horizontally as well as vertically,
which makes it very confusing.
(Assignee)

Comment 1

16 years ago
Created attachment 76600 [details] [diff] [review]
uses the timer hit count text as the anchor text - ends horizontal scrolling

A patch to be applied after the one attached to bug

http://bugzilla.mozilla.org/show_bug.cgi?id=132071

which uses different text for the anchor text.	It's not nearly as nice on the
eye as the original output (there are preceeding underscores, e.g.), but it
does produce a web page which doesn't flip back and forth horizontally and
confusingly as links are followed.

Comment 2

16 years ago
Marking NEW for patch loving./
Assignee: asa → attinasi
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
QA Contact: doron → petersen
Summary: long anchor text in jprof output causes horizontal jumping → [PATCH] long anchor text in jprof output causes horizontal jumping

Updated

16 years ago
Priority: -- → P3

Updated

16 years ago
Target Milestone: --- → Future
David, would you be a good person to review this patch?  Assuming it still applies?
Depends on: 132071
Created attachment 140560 [details] [diff] [review]
Merged to tip

Unfortunately, this linkifies the leading spaces....
Attachment #76600 - Attachment is obsolete: true
Comment on attachment 140560 [details] [diff] [review]
Merged to tip

David, what do you think?
Attachment #140560 - Flags: review?(dbaron)
Attachment #140560 - Flags: review?(dbaron) → review+
Checked in.
Assignee: attinasi → morrison
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.