web apis for history of signoffs to scheduled changes

NEW
Unassigned

Status

Release Engineering
Balrog: Backend
P3
normal
a year ago
a year ago

People

(Reporter: bhearsum, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=python])

(Reporter)

Description

a year ago
We keep track of when signoffs to scheduled changes happens in Balrog's database, but we don't expose them anywhere in the API.

The current state of signoffs get returned as part of list of scheduled changes, eg: in a GET to /scheduled_changes/rules.

We could do this in two ways:
1) Add a separate endpoint to get the history of signoffs to a scheduled change, eg: /scheduled_changes/rules/:sc_id/signoffs/revisions
2) Integrate with regular scheduled change history (eg: /scheduled_changes/rules/:sc_id/revisions). 

The former would be simpler to implement, but the latter is more consistent with the existing scheduled changes api, where we've been treating each scheduled change as one object, despite the fact that they are stored across 3 tables (scheduled_changes, conditions, and signoffs). Going this route may mean we need to increase data_version in each of these tables whenever something from one of them changes.
(Reporter)

Updated

a year ago
Blocks: 1340171
You need to log in before you can comment on or make changes to this bug.