Closed
Bug 1340191
Opened 7 years ago
Closed 7 years ago
No Audio Notification for BBC Radio
Categories
(Firefox for Android Graveyard :: Audio/Video, defect, P1)
Tracking
(fennec+, firefox51 disabled, firefox52 verified, firefox53 verified, firefox54 verified)
VERIFIED
FIXED
Firefox 54
People
(Reporter: ioana.chiorean, Assigned: alwu)
References
Details
Attachments
(2 files)
59 bytes,
text/x-review-board-request
|
sebastian
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
2.60 KB,
patch
|
alwu
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Pixel (Android 7.1.1) Nightly 2017-02-13 STR: 1. Go to bbc.co.uk/radio4 2. Click on "Listen live" 3. Switch to your home screen 4. Observe the notification bar Expected results: - It should be present a notification to let me know i am listening to an audio in Fennec and I should be able to pause/resume Actual results: - No audio notification is present/generated
Reporter | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7ca3abda8c76ad9d61b12d6fa87f070a7717231
Updated•7 years ago
|
Priority: -- → P1
Comment hidden (mozreview-request) |
Updated•7 years ago
|
tracking-fennec: ? → +
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8839406 [details] Bug 1340191 - reverse the checking condition. https://reviewboard.mozilla.org/r/114078/#review116210
Attachment #8839406 -
Flags: review?(s.kaspari) → review+
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9294b1e9b7e2 reverse the checking condition. r=sebastian
Comment 8•7 years ago
|
||
51 might technically be affected, but in practice this feature was still behind a Nightly flag at that time (bug 1290836).
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9294b1e9b7e2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 11•7 years ago
|
||
Verified as fixed on build 54.0a1 (2017-02-22); Device: Motorola Nexus 6 (Android 7.0) and Huawei MediaPad M2 (Android 5.1.1). Media control notification is displayed.
Assignee | ||
Comment 12•7 years ago
|
||
Comment on attachment 8839406 [details] Bug 1340191 - reverse the checking condition. Approval Request Comment [Feature/Bug causing the regression]: Fix the regression bug [User impact if declined]: Media control won't be showed [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment0 [List of other uplifts needed for the feature/fix]: bug1326114 is related, and this bug needs to be uplift before bug1326114 [Is the change risky?]: No [Why is the change risky/not risky?]: Only affect Fennec, and it's UI level changed [String changes made/needed]: No Note. This bug needs to be uplift before bug1326114
Flags: needinfo?(alwu)
Attachment #8839406 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 13•7 years ago
|
||
Approval Request Comment [Feature/Bug causing the regression]: Fix the regression bug [User impact if declined]: Media control won't be showed [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment0 [List of other uplifts needed for the feature/fix]: bug1326114 is related, and this bug needs to be uplift before bug1326114 [Is the change risky?]: No [Why is the change risky/not risky?]: Only affect Fennec, and it's UI level changed [String changes made/needed]: No Note. This bug needs to be uplift before bug1326114
Attachment #8842282 -
Flags: review+
Attachment #8842282 -
Flags: approval-mozilla-beta?
Comment 14•7 years ago
|
||
Hi :alwu, Please fill out the bug or feature bug in the uplift template not fill "the regression bug" for better judgment. I can't tell which bug caused the regression.
Flags: needinfo?(alwu)
Assignee | ||
Comment 15•7 years ago
|
||
[Feature/Bug causing the regression]: Display the media control for BBC website.
Flags: needinfo?(alwu)
Comment 16•7 years ago
|
||
Comment on attachment 8842282 [details] [diff] [review] Bug 1340191 - reverse the checking condition. (for-beta) Too late for 52.
Attachment #8842282 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment 17•7 years ago
|
||
Comment on attachment 8839406 [details] Bug 1340191 - reverse the checking condition. Per discussion with :bwu, the feature bug should be bug 1268368. Fix audio notification for BBC radio and was verified. Aurora53+.
Attachment #8839406 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 18•7 years ago
|
||
Comment on attachment 8842282 [details] [diff] [review] Bug 1340191 - reverse the checking condition. (for-beta) fennec media control fix After more explanation in bug 1326114 let's take these two changes.
Attachment #8842282 -
Flags: approval-mozilla-beta- → approval-mozilla-beta+
Comment 19•7 years ago
|
||
Same story as bug 1326114, this should be manually verified.
Flags: qe-verify+
Comment 20•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/29f91acdc27f
Updated•7 years ago
|
Attachment #8842282 -
Attachment is patch: true
Comment 21•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/4011ea8c0204 https://hg.mozilla.org/releases/mozilla-release/rev/4011ea8c0204
Comment 22•7 years ago
|
||
Verified as fixed on build 53.0a2 (2017-03-03) and 52 Beta 11; Device: Nexus 9 (Android 7.1.1) and Samsung Galaxy Note 4 (Android 5.0.1). Media control notification is displayed.
Comment 23•6 years ago
|
||
Based on comment 22 I will remove the qe-verify flag, thanks.
Flags: qe-verify+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•