Closed Bug 13402 Opened 20 years ago Closed 20 years ago

Should cache string bundles

Categories

(MailNews Core :: MIME, defect, P3)

All
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Bienvenu, Assigned: rhp)

Details

(Whiteboard: [Perf])

I believe we can get a performance win by caching string bundles instead of
loading the string resource file every time we need a string.

Here are the four place mime is creating string bundles that could be cached:

E:\raptor\mozilla\mailnews\mime\cthandlers\vcard\mimevcrd.cpp(1981):    res =
sBundleService->CreateBundle(VCARD_URL, locale, &sBundle);
E:\raptor\mozilla\mailnews\mime\cthandlers\vcard\mimevcrd.cpp(1990):    res =
sBundleService->CreateBundle(pURI, locale, &sBundle);
E:\raptor\mozilla\mailnews\mime\emitters\src\nsEmitterUtils.cpp(145):    res =
sBundleService->CreateBundle(propertyURL, locale, &sBundle);
E:\raptor\mozilla\mailnews\mime\src\mimemoz2.cpp(1211):    res =
sBundleService->CreateBundle(propertyURL, locale, &sBundle);

I've fixed the leaks of the string bundles.
I could't see these routines getting hit the second time I loaded a message, and
a couple of them don't seem to get called at all, so this bug may be invalid
until they start getting used.
Whiteboard: [Perf]
Putting on [Perf] radar.
Target Milestone: M14
M14
Bulk change to assigned.

- rhp
Target Milestone: M14 → M12
I should get to this in M13. Just work that needs to be done...nothing fancy
here.

- rhp
I should get to this in M12. Just work that needs to be done...nothing fancy
here.

- rhp
Ok, I have this fixed in my tree and will checkin when the tree reopens.

- rhp
Summary: should cache string bundles → FIXED: should cache string bundles
Just marking this fixed in the summary for my own tracking purposes.

- rhp
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: FIXED: should cache string bundles → Should cache string bundles
Checked this in today.

- rhp
QA Contact: lchiang → suresh
Looks right to me :-)
As per comment from rhp, I'm marking this as Verified. Thanks Rich.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.