1340231 - Ensure valgrind works well with rust code in Firefox

Status: NEW

(Core :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Output

I tried using Valgrind on a local QuantumRender build, and it produced some warnings in rust code. I'm not sure if they are legitimate or not, but I'm filing this bug to ensure that Valgrind can be used with rust code and generates correct warnings/errors. Julian said he would look into it if I can provide STR, so here they are:

1. I'm on Ubuntu 16.04.1 LTS, x86_64 system
2. I used the stock valgrind provided by apt-get, which is valgrind-3.11.0
3. I'm building a version of Firefox from the graphics branch, specifically the revision at [1]. (This is similar to what's in m-c, but stuff in m-c is currently broken, so don't use that)
4. I built Firefox with the mozconfig at [2]. In particular, this includes the options as per the MDN page at [3] and also includes `ac_add_options --enable-webrender` to turn on webrender (hence making it a "Quantum Render" build).
5. Since --debugger-args seems to be broken as of late, I ran this command: `G_SLICE=always-malloc xr ./mach mochitest --subsuite webgl --keep-open=false --debugger=memcheck dom/canvas/test/webgl-conf/generated/test_conformance__attribs__gl-bindAttribLocation-matrix.html`
where the "memcheck" program is the wrapper around valgrind at [4].

This runs and produces output, attached. It seems like it could be legitimate, but I would like to make sure.

[1] https://hg.mozilla.org/projects/graphics/rev/2a8f4debee42
[2] https://github.com/staktrace/moz-scripts/blob/1bdc9d3a4252d0385c6b6bae12fd62fa48a097ef/mozconfig.Linux-host-webrender-valgrind
[3] https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Valgrind
[4] https://github.com/staktrace/moz-scripts/blob/170b8194b959bc0cf2788bae6ea97a0d68b3e59f/memcheck

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Hello, I'm asking your help with an experiment with making decisions on bugs. You've been needinfo'ed on this bug. I'd like you to take one action to help this bug make progress toward a decision. The things you can do include:

* If you know or have a good guess of which product and component this bug belongs to, change the product and component of the bug
* If you know of the right person to ask about this bug, redirect the needinfo to them
* If you cannot reproduce the bug, close it

Comment 2

[Julian Seward [:jseward]]

(In reply to Emma Humphries ☕️ (she/her) [:emceeaich] (UTC-8) +needinfo me from comment #1)
> * If you know or have a good guess of which product and component this bug
> belongs to, change the product and component of the bug

I assigned it to me since I am the person who should really try to fix it.

Comment 3

[Massimo Fidanza]

Will this bug be fixed?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 5

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.