1340232 - Remove unused -webkit css

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

This tracks the removal of unused -webkit css properties, which due to browser evolution is now supported on Chrome with their non -webkit equivalents.

Since there are more than fifty removals across Treeherder, I'd like to do them in smaller chunks, according to their major UI. I will test each for any unexpected changes.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:remove-webkit-css-pinboard > mozilla:master

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8838150 [details] [review]
[treeherder] tojon:remove-webkit-css-pinboard > mozilla:master

Pinboard removals for review.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5fee89a24aaa16a1c8ae48c4297717b23c89762b
Bug 1340232 - Remove unused -webkit css in the pinboard (#2182)

Comment 4

[William Lachance (:wlach)]

Thanks Jonathan!

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:remove-webkit-css-infopanel > mozilla:master

Comment 6

[Jonathan French (:jfrench)]

Next up, info panel removals for review.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4086a7fb2f4b7c25e49bba51235fabb8e2bd452b
Bug 1340232 - Remove unused -webkit css from info-panel (#2189)

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8838736 [details] [review]
[treeherder] tojon:remove-webkit-css-infopanel > mozilla:master

Thank you, merged!

Comment 9

[Jonathan French (:jfrench)]

Next up, main page, resultset bar and navbar for removals.

Comment 10

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:remove-webkit-css-mainpage > mozilla:master

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/131a67eb856abf79d8d3a899d02586b383375ed6
Bug 1340232 - Remove unused -webkit css from main page (#2197)

Comment 12

[William Lachance (:wlach)]

Hey jfrench, it unfortunately looks like (on further testing) your last change results in the job details panel taking up more than the usual vertical space if you click on a job on a small view (like try):

https://treeherder.allizom.org/#/jobs?repo=try&revision=cc6dcc70342529fc2a5210266430a354b69f036a&selectedJob=74496437

Reverting the commit in comment 11 (131a67eb856abf79d8d3a899d02586b383375ed6) fixes the issue.

Could you have a look when you get a chance?

Comment 13

[Jonathan French (:jfrench)]

Yup, I will have a look. So much for my having tested pushes only on inbound and central :)

Comment 14

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:remove-webkit-css-main-tweak > mozilla:master

Comment 15

[William Lachance (:wlach)]

Comment on attachment 8841234 [details] [review]
[treeherder] tojon:remove-webkit-css-main-tweak > mozilla:master

r+ with comment fixed or removed. thanks for jumping on this :)

Comment 16

[Jonathan French (:jfrench)]

I removed the old comment, ready for merge.

Comment 17

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2a7783727be3b338c8640bdd8802afc49f63a5cf
Bug 1340232 - Return flex property for small push reflows (#2205)

Comment 18

[Jonathan French (:jfrench)]

Next up, Perf.

Comment 19

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:remove-webkit-css-perf > mozilla:master

Comment 20

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bb5d4e5540b3f74bc09de482b3d3f5a5c0c35823
Bug 1340232 - Remove unused -webkit css from perf (#2235)

Comment 21

[Jonathan French (:jfrench)]

So I think we can call this bug done. There is still the Logviewer webkit removals to do, but I think it has a bunch of other unused stuff since the unified Logviewer was implemented; so we can do it in its own bug.