Closed
Bug 1340284
Opened 7 years ago
Closed 7 years ago
Audit instances where Compatibility is used in content process.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Whiteboard: JAWS, dolphin)
Attachments
(1 file)
1.67 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
There are places such as https://dxr.mozilla.org/mozilla-central/source/accessible/windows/msaa/ServiceProvider.cpp#75-83 that do not work in content process since compatibility is not initialized in content process.
Assignee | ||
Updated•7 years ago
|
Keywords: leave-open
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8838225 -
Flags: review?(tbsaunde+mozbugs)
Comment 2•7 years ago
|
||
Comment on attachment 8838225 [details] [diff] [review] 1340284 1 > // Can get to IAccessibleApplication from any node via QS > if (aGuidService == IID_IAccessibleApplication || >- (Compatibility::IsJAWS() && aIID == IID_IAccessibleApplication)) { >+ aIID == IID_IAccessibleApplication) { you should really comment this weird thing for jaws.
Attachment #8838225 -
Flags: review?(tbsaunde+mozbugs) → review+
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d96998411971 remove JAWS condition when retrieving IAccessibleApplication in ServiceProvider. r=tbsaunde
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d96998411971
Assignee | ||
Comment 5•7 years ago
|
||
There are 2 remaining issues, I believe that would need to be addressed when e10s + a11y is the default: 1) https://dxr.mozilla.org/mozilla-central/source/accessible/windows/msaa/RootAccessibleWrap.cpp#33-44 Here we need to make sure that hWnd visibility (hidden for background, visible for forefront) is set in parent process. I believe smaug suggested we look at doing it in TabParent::SetDocShellIsActive (https://dxr.mozilla.org/mozilla-central/source/dom/ipc/TabParent.cpp?q=file%3Atabparent.cpp&redirect_type=single#2718-2738) 2) related to old jaws and IA2 support https://dxr.mozilla.org/mozilla-central/source/accessible/windows/ia2/ia2Accessible.cpp#49
Assignee | ||
Updated•7 years ago
|
Assignee: yzenevich → nobody
Status: ASSIGNED → NEW
Updated•7 years ago
|
Assignee: nobody → tbsaunde+mozbugs
Updated•7 years ago
|
Flags: needinfo?(jmathies)
Updated•7 years ago
|
Flags: needinfo?(jmathies) → needinfo?(davidp99)
Comment 6•7 years ago
|
||
I took a look at this today, I think I have the dolphin window activation / deactivation setup. However if we want to support dolphin we should really test with it or something. For the IAccessible2 business it seems to me we should see what happens with recent jaws before we worry about making hacks to support 10 year old jaws work with e10s. The plugin junk in nsAccessibilityService.cpp may also be an issue, but not high prio compared to other things that need done. I think the rest of it has already been made to work with e10s.
Flags: needinfo?(davidp99)
Updated•7 years ago
|
Whiteboard: aes+, JAWS, dolphin → JAWS, dolphin
Comment 7•7 years ago
|
||
Yura can you triage this one too?
Assignee: tbsaunde+mozbugs → nobody
Flags: needinfo?(yzenevich)
Assignee | ||
Comment 8•7 years ago
|
||
Addressed by bug 1362420
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(yzenevich)
Resolution: --- → FIXED
Comment 9•6 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Updated•6 years ago
|
Assignee: nobody → yzenevich
You need to log in
before you can comment on or make changes to this bug.
Description
•