1340312 - Stop passing installed add-ons data to discovery pane

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We currently pass a list of all the installed add-ons to the discovery pane. It doesn't use it anymore instead using the mozAddonManager API to get what it needs so we should stop doing this.

Comment 1

[Mark Striemer [:mstriemer]]

I filed https://github.com/mozilla/addons-frontend/issues/1840 to track this change for the disco pane.

Could we get whether the user has any themes or extensions installed instead? Eg:

{"hasExtensions": false, "hasThemes": true}

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1340312: Stop passing installed add-ons data to discovery pane.

Review commit: https://reviewboard.mozilla.org/r/113230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113230/

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8838281 [details]
Bug 1340312: Stop passing installed add-ons data to discovery pane.

https://reviewboard.mozilla.org/r/113230/#review114696

::: toolkit/mozapps/extensions/content/extensions.js
(Diff revision 1)
> -        this._loadURL(this.homepageURL.spec, false, notifyInitialized);
> +      this._loadURL(this.homepageURL.spec, false, notifyInitialized);
> -      else
> +    else
> -        notifyInitialized();
> +      notifyInitialized();
> -    }
> -
> -    if (Services.prefs.getBoolPref(PREF_GETADDONS_CACHE_ENABLED) == false) {

This looks like the only use of PREF_GETADDONS_CACHE_ENABLED in this file so that declaration can go too.  Same with PREF_GETADDONS_CACHE_ID_ENABLED.  I'm not familiar with those prefs, you probably know better than I do if there's further removal that can happen since these references are gone.

Comment 4

[Dave Townsend [:mossop]]

(In reply to Mark Striemer [:mstriemer] from comment #1)
> I filed https://github.com/mozilla/addons-frontend/issues/1840 to track this
> change for the disco pane.
> 
> Could we get whether the user has any themes or extensions installed
> instead? Eg:
> 
> {"hasExtensions": false, "hasThemes": true}

I can do this, but basically everyone will have hasThemes=true because of the default themes we ship. If you want me to somehow try to filter those out let me know.

Comment 5

[[e-mail]]

We manually filter out bundled add-ons with a list maintained in the disco pane code: https://github.com/mozilla/addons-frontend/commit/6331f6b8f161698f0e1e5f1e04c61b43b6467a1c#diff-8423fedb8be9cc2453639bbbe1fe40e3L13 but it's something that needs to be continually updated.

Comment 6

[Mark Striemer [:mstriemer]]

Filtering them out would be great if there's some way to be able to tell if it's a default theme or system extension in Firefox. Otherwise I guess we'll still need the GUIDs so we can use our existing filtering.

Comment 7

[Markus Jaritz [:designakt] (UX)]

(In reply to Mark Striemer [:mstriemer] from comment #6)
> Filtering them out would be great if there's some way to be able to tell if
> it's a default theme or system extension in Firefox. Otherwise I guess we'll
> still need the GUIDs so we can use our existing filtering.

In "about:telemetry > Environment Data > addons" extensions have an entry called isSystem: true to indicate that they are system addons. For themes I haven't seen that unfortunately, so we might still need the GUIDs for those.

Comment 8

[Dave Townsend [:mossop]]

This has gotten more complicated than I had originally expected. Given that we still need to do filtering somewhere I propose to leave things as they are with AMO doing the filtering server side where it can be updated without needing a Firefox update making this bug a wontfix.