1340373 - [fa][3.1] Sign-off for Persian on Focus

Status: RESOLVED FIXED

(Mozilla Localizations :: fa / Persian, defect)

Description

[Delphine Lebédel]

Since this is a new locale on Focus for v3.1, we're going to need an explicit sign-off from community.

Deadline Feb.24

Stefan regularly provides screenshots for testing your work on dev.l10n, and that you can find here: https://people-mozilla.org/~sarentz/focus/screenshots/latest/

Please use indicate your sign-off by closing this bug as RESOLVED FIXED. Thank you!

Comment 1

[Yaron Shahrabani]

Hi, there is an issue in this screenshot, the top line starts with a dot, it should be at the end of the sentence, sadly my Persian is not good enough to understand if the sentence is in the correct order:
https://people-mozilla.org/~sarentz/focus/screenshots/latest/Focus/iPhone7Plus/fa/iPhone7Plus-11About-d41d8cd98f00b204e9800998ecf8427e.png

Another one here (the red line under the X):
https://people-mozilla.org/~sarentz/focus/screenshots/latest/Focus/iPhone7Plus/fa/iPhone7Plus-13SafariIntegrationInstructions-d41d8cd98f00b204e9800998ecf8427e.png

These both appear in Hebrew but not in Arabic, probably directionality characters.

Comment 2

[Yaron Shahrabani]

Delphine, I checked again, I can't see any directionality characters in https://github.com/mozilla-mobile/focus/blob/cb3319b58922a40baae849f467997bbbc6f0fbf2/Blockzilla/ar.lproj/Localizable.strings#L38

So I guess there's something else making this string appear in the correct order.

Comment 3

[Arash Mousavi [:Arash-M]]

(In reply to Yaron Shahrabani from comment #2)
> Delphine, I checked again, I can't see any directionality characters in
> https://github.com/mozilla-mobile/focus/blob/
> cb3319b58922a40baae849f467997bbbc6f0fbf2/Blockzilla/ar.lproj/Localizable.
> strings#L38
> 
> So I guess there's something else making this string appear in the correct
> order.

Thanks Yaron. That's simply because the sentence is started with an LTR character (Firefox Focus) so they assume the whole sentence is LTR. I have to rewrite the sentence in a way that it starts with a character from Persian alphabet so it becomes RTL. Many other platforms like GTK+ also uses the same technique to detect text direction.

Comment 4

[Arash Mousavi [:Arash-M]]

Current state of translations looks fine to me. Thanks a lot Delphine and Yaron.