Closed Bug 1340396 Opened 3 years ago Closed 3 years ago

Add window.getAppLocales for ChromeOrXBL

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

(Whiteboard: [milestone5])

Attachments

(1 file, 1 obsolete file)

The consensus was to use browser UI locale for localization. To get this info, we are exposing mozilla::intl::LocaleService::GetAppLocales() (see Bug 1332207) for chrome and xbl.
Attached patch patch, v1. (obsolete) — Splinter Review
Assignee: nobody → jjong
Comment on attachment 8838405 [details] [diff] [review]
patch, v1.

Review of attachment 8838405 [details] [diff] [review]:
-----------------------------------------------------------------

Olli, it seems that we can get only user preferred language using navigator.language(s), but there is no way to get browser UI locale, so we are adding this function and expose it to chrome/xbl only.
Attachment #8838405 - Flags: review?(bugs)
Comment on attachment 8838405 [details] [diff] [review]
patch, v1.

I still wonder if all the work requiring this information could be done in C++ or chrome JS side.
Attachment #8838405 - Flags: review?(bugs) → review+
Attached patch patch, v2.Splinter Review
update bug number and commit message, carrying r+.
Attachment #8838405 - Attachment is obsolete: true
Attachment #8839048 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/711456564e1e
Add window.getAppLocales() for ChromeOrXBL. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/711456564e1e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.