Closed
Bug 1340396
Opened 7 years ago
Closed 7 years ago
Add window.getAppLocales for ChromeOrXBL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
Details
(Whiteboard: [milestone5])
Attachments
(1 file, 1 obsolete file)
4.64 KB,
patch
|
jessica
:
review+
|
Details | Diff | Splinter Review |
The consensus was to use browser UI locale for localization. To get this info, we are exposing mozilla::intl::LocaleService::GetAppLocales() (see Bug 1332207) for chrome and xbl.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → jjong
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8838405 [details] [diff] [review] patch, v1. Review of attachment 8838405 [details] [diff] [review]: ----------------------------------------------------------------- Olli, it seems that we can get only user preferred language using navigator.language(s), but there is no way to get browser UI locale, so we are adding this function and expose it to chrome/xbl only.
Attachment #8838405 -
Flags: review?(bugs)
Comment 3•7 years ago
|
||
Comment on attachment 8838405 [details] [diff] [review] patch, v1. I still wonder if all the work requiring this information could be done in C++ or chrome JS side.
Attachment #8838405 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 4•7 years ago
|
||
update bug number and commit message, carrying r+.
Attachment #8838405 -
Attachment is obsolete: true
Attachment #8839048 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c8e3fe909cd25355ac58a183c43e0e7568f0699&group_state=expanded
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/711456564e1e Add window.getAppLocales() for ChromeOrXBL. r=smaug
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/711456564e1e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•