Closed Bug 1340401 Opened 4 years ago Closed 4 years ago

"mach vendor rust" fails with "NameError: global name 'FILESIZE_LIMIT' is not defined"

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: heycam, Assigned: froydnj)

References

Details

Attachments

(1 file)

I ran |mach vendor rust| and I got this error:

NameError: global name 'FILESIZE_LIMIT' is not defined
  File "/z/autoland/python/mozbuild/mozbuild/mach_commands.py", line 1603, in vendor_rust
    vendor_command.vendor(**kwargs)
  File "/z/autoland/python/mozbuild/mozbuild/vendor_rust.py", line 127, in vendor
    if size > FILESIZE_LIMIT:

It looks like that constant isn't defined.
Flags: needinfo?(nfroyd)
Whoops.  Trimmed a little too much when I was shuffling things around.
Attachment #8838574 - Flags: review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7e5fc47262
add back definition of FILESIZE_LIMIT; r=obvious-bustage
Thanks for the bug report!  Sorry about the bustage. :(
Assignee: nobody → nfroyd
Flags: needinfo?(nfroyd)
https://hg.mozilla.org/mozilla-central/rev/fb7e5fc47262
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.