Closed Bug 1340434 Opened 5 years ago Closed 5 years ago

stylo: Request complete log for tests with failure pattern and add mark for filtered failures

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(2 files, 2 obsolete files)

So that it is easier to know what really happens for mismatches.
Comment on attachment 8838400 [details]
Bug 1340434 part 2 - Request complete log and mark suppressed unexpecteds.

https://reviewboard.mozilla.org/r/113342/#review114852
Attachment #8838400 - Flags: review?(jmaher) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1081a37acef9
Request complete log and mark suppressed unexpecteds. r=jmaher
Attached patch followup (obsolete) — Splinter Review
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83b51e1ba3e1
followup - Fix call before define error in js. a=tomcat
Attached patch followup 2 (obsolete) — Splinter Review
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c217cd4e9dc
followup 2 - Fix call before define error in js again. a=tomcat
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88736bccd951
Backed out changeset 5c217cd4e9dc 
https://hg.mozilla.org/integration/autoland/rev/c7dee138e284
Backed out changeset 83b51e1ba3e1 
https://hg.mozilla.org/integration/autoland/rev/1ba4a5a50a31
Backed out changeset 1081a37acef9 for ongoing failures in test_acid3_test46.html
> Log file size 90003794 is greater than max allowed 52428800!

Probably we really cannot request complete log for that...
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
this is an artificial limit for buildbot that was built into mozharness- now these tests are run via taskcluster and there is no limit, maybe we should remove this or set it higher:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/unittests/linux_unittest.py#293
Some people complain to me that we should provide the complete log so that they can debug without doing whole stylo build locally.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Attachment #8838483 - Attachment is obsolete: true
Attachment #8838505 - Attachment is obsolete: true
Comment on attachment 8862768 [details]
Bug 1340434 part 1 - Increase the max log size for linux unittest.

https://reviewboard.mozilla.org/r/134642/#review137612

this is fine- keep in mind that this will only work for taskcluster tests (which is all of linux unittests right now), so if we run these tests on osx or windows, they still use buildbot and will have log file restrictions.
Attachment #8862768 - Flags: review?(jmaher) → review+
OK, thanks. Hopefully we can fix majority of failures listed before we enable the tests on other platforms.
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88a3448c6bce
part 1 - Increase the max log size for linux unittest. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/f6d02271397b
part 2 - Request complete log and mark suppressed unexpecteds. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/88a3448c6bce
https://hg.mozilla.org/mozilla-central/rev/f6d02271397b
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.