1340434 - stylo: Request complete log for tests with failure pattern and add mark for filtered failures

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

So that it is easier to know what really happens for mismatches.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1340434 part 2 - Request complete log and mark suppressed unexpecteds.

Review commit: https://reviewboard.mozilla.org/r/113342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113342/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8838400 [details]
Bug 1340434 part 2 - Request complete log and mark suppressed unexpecteds.

https://reviewboard.mozilla.org/r/113342/#review114852

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1081a37acef9
Request complete log and mark suppressed unexpecteds. r=jmaher

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Attachment: followup

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83b51e1ba3e1
followup - Fix call before define error in js. a=tomcat

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Attachment: followup 2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c217cd4e9dc
followup 2 - Fix call before define error in js again. a=tomcat

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88736bccd951
Backed out changeset 5c217cd4e9dc 
https://hg.mozilla.org/integration/autoland/rev/c7dee138e284
Backed out changeset 83b51e1ba3e1 
https://hg.mozilla.org/integration/autoland/rev/1ba4a5a50a31
Backed out changeset 1081a37acef9 for ongoing failures in test_acid3_test46.html

Comment 9

[Xidorn Quan [:xidorn] UTC+11]

> Log file size 90003794 is greater than max allowed 52428800!

Probably we really cannot request complete log for that...

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

this is an artificial limit for buildbot that was built into mozharness- now these tests are run via taskcluster and there is no limit, maybe we should remove this or set it higher:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/unittests/linux_unittest.py#293

Comment 11

[Xidorn Quan [:xidorn] UTC+11]

Some people complain to me that we should provide the complete log so that they can debug without doing whole stylo build locally.

Comment 12

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1340434 part 1 - Increase the max log size for linux unittest.

Review commit: https://reviewboard.mozilla.org/r/134642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134642/

Comment 13

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8838400 [details]
Bug 1340434 part 2 - Request complete log and mark suppressed unexpecteds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/113342/diff/1-2/

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8862768 [details]
Bug 1340434 part 1 - Increase the max log size for linux unittest.

https://reviewboard.mozilla.org/r/134642/#review137612

this is fine- keep in mind that this will only work for taskcluster tests (which is all of linux unittests right now), so if we run these tests on osx or windows, they still use buildbot and will have log file restrictions.

Comment 15

[Xidorn Quan [:xidorn] UTC+11]

OK, thanks. Hopefully we can fix majority of failures listed before we enable the tests on other platforms.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a3448c6bce
part 1 - Increase the max log size for linux unittest. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/f6d02271397b
part 2 - Request complete log and mark suppressed unexpecteds. r=jmaher

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/88a3448c6bce
https://hg.mozilla.org/mozilla-central/rev/f6d02271397b