Closed
Bug 1340451
Opened 7 years ago
Closed 7 years ago
don't use weak frames for reflow callbacks in nsMenuFrame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
5.64 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Weak frames are stored in a linked list, so are not fast. Hence they are not meant to be used when there can be a lot of them active at the same time. When constructing large selects with lots of options we create one for every option.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8838430 -
Flags: review?(mats)
Comment 2•7 years ago
|
||
I don't see why we need to tie this to reflow at all. Can we simply use a script runner here instead? It seems simpler, and more performant than a reflow callback. (this compiles but is otherwise untested)
Flags: needinfo?(tnikkel)
Comment 3•7 years ago
|
||
BTW, why is this blocking bug 1118086? Is the e10s <select> combobox implemented using XUL frames!?!?
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #2) > I don't see why we need to tie this to reflow at all. > Can we simply use a script runner here instead? > It seems simpler, and more performant than a reflow callback. > (this compiles but is otherwise untested) This doesn't fix the problem of having many weak frames alive at the same time. (In reply to Mats Palmgren (:mats) from comment #3) > BTW, why is this blocking bug 1118086? > Is the e10s <select> combobox implemented using XUL frames!?!? Yes, sadly.
Flags: needinfo?(tnikkel)
Comment 5•7 years ago
|
||
Comment on attachment 8838707 [details] [diff] [review] script runner Oh, I guess these do pile up during frame construction...
Attachment #8838707 -
Attachment is obsolete: true
Comment 6•7 years ago
|
||
Comment on attachment 8838430 [details] [diff] [review] patch LGTM, r=mats
Attachment #8838430 -
Flags: review?(mats) → review+
Pushed by tnikkel@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6af6e3b0247f Don't use weak frames for reflow callbacks in nsMenuFrame. r=mats
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6af6e3b0247f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•