1340469 - Get licensing signoff on using JSZip for supporting compression HAR log

Status: RESOLVED FIXED

(mozilla.org :: Licensing, task)

Description

[Ricky Chien [:rickychien] (inactive)]

As https://bugzilla.mozilla.org/show_bug.cgi?id=1340368#c5 we have to add JSZip license to about:license to cover the latest versions of JSZip that we're using.

grev, could you please tell me what should I do to update license.html? Thanks!

https://stuk.github.io/jszip/
https://github.com/Stuk/jszip/blob/master/LICENSE.markdown

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Gerv: is JSZip license ok, can we add it into m-c?

Here is the license file:
https://github.com/Stuk/jszip/blob/master/LICENSE.markdown

JSZip is dual-licensed. You may use it under the MIT license or the GPLv3 license.

Honza

Comment 2

[Gervase Markham [:gerv]]

Yes; please add it to about:license. It should be obvious how to do this (alphabetical order, title "JSZip License") but let me know if not, and give me a patch to review.

Gerv

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1340469 - Get licensing signoff on using JSZip

Review commit: https://reviewboard.mozilla.org/r/114388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114388/

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8839817 [details]
Bug 1340469 - Get licensing signoff on using JSZip

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114388/diff/1-2/

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8839817 [details]
Bug 1340469 - Get licensing signoff on using JSZip

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114388/diff/2-3/

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 8839817 [details]
Bug 1340469 - Get licensing signoff on using JSZip

https://reviewboard.mozilla.org/r/114388/#review116500

::: toolkit/content/license.html:3633
(Diff revision 3)
>  
>      <hr>
>  
> +    <h1><a id="jszip"></a>JSZip License</h1>
> +
> +    <p>This license applies to various files in the Mozilla codebase.</p>

Are the files not grouped together in a directory somewhere, then?

::: toolkit/content/license.html:3638
(Diff revision 3)
> +    <p>This license applies to various files in the Mozilla codebase.</p>
> +
> +<pre>
> +The MIT License
> +===============
> +

Remove these three lines

::: toolkit/content/license.html:3661
(Diff revision 3)
> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> +THE SOFTWARE.
> +
> +
> +GPL version 3
> +=============

Er, no. Please remove the entire GPLv3 section. We are using the code under the MIT license, so that's the only one we need to reproduce. Having a copy of the GPLv3 in here will deeply confuse people.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8839817 [details]
Bug 1340469 - Get licensing signoff on using JSZip

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114388/diff/3-4/

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Grev, three issues are addressed so please check it again. thanks!

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8839817 [details]
Bug 1340469 - Get licensing signoff on using JSZip

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114388/diff/4-5/

Comment 10

[Gervase Markham [:gerv]]

Comment on attachment 8839817 [details]
Bug 1340469 - Get licensing signoff on using JSZip

https://reviewboard.mozilla.org/r/114388/#review117126

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aecc3e03028
Get licensing signoff on using JSZip r=gerv

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1aecc3e03028