1340473 - [Ubuntu] The X button from Developer Toolbar is barely visible with Compact Dark theme applied

Status: RESOLVED DUPLICATE of bug 1341123

(Firefox :: Theme, defect)

Description

[Ciprian Georgiu, Desktop QA]

[Affected versions]:
- latest Nightly 54.0a1 (2017-02-16)
- latest Aurora 53.0a2 (2017-02-16)

[Affected platforms]:
- Ubuntu 16.04 x64 LTS

[Steps to reproduce]:
1. Launch Firefox
2. Enable Compact Dark theme from about:addons
3. Open Developer Toolbar (Shift + F2) and inspect the X button from the right side.

[Expected result]:
- The X button has a lighter color in Dev Toolbar which makes it more noticeable.

[Actual result]:
- The X button from Dev Toolbar is barely visible, and it's difficult for users to see it with Compact Dark theme applied.

[Regression range]:
- This is not a regression since I can reproduce this with older builds (Nightly 53.0a1 2017-01-15) where this feature first landed.

[Additional notes]:
- I noticed that in Sidebar Bookmarks (Ctrl + B) the X button it's more visible even though it has the same dark background - see the attached screenshot. On other platforms like Windows or Mac OS X I cannot see this issue.

Comment 1

[:Gijs (he/him)]

Why did you mark this security-sensitive?

Comment 2

[Ciprian Georgiu, Desktop QA]

I've flagged this as a sec-bug by mistake. Can you please make this accessible to all users?

Comment 3

[Ciprian Georgiu, Desktop QA]

Attachment: close button "X" - issue.jpg

Thank you! I upload again the screenshot with this issue.

Comment 4

[Bram Pitoyo [:bram]]

If we fix bug 1341123, which I just filed, will we also fix this bug? Or perhaps this is an entirely separate CSS issue?

Comment 5

[:Gijs (he/him)]

(In reply to Bram Pitoyo [:bram] from comment #4)
> If we fix bug 1341123, which I just filed, will we also fix this bug? Or
> perhaps this is an entirely separate CSS issue?

I believe these are separate XUL bits, but the devtools know is better-placed to answer that question.

Comment 6

[Patrick Brosset <:pbro>]

Forwarding to Mike who knows about the developer toolbar.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Yes, fixing bug 1341123 will also fix this.