1340525 - Clicking on an anchored link doesn't jump to the named anchor if the hash doesn't change

Status: RESOLVED WORKSFORME

(Core :: DOM: Navigation, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Go to https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links
2. Move up the page.
3. Click on "Links" in the table of contents

Expected:
* We go to the Links part

Actual:
* Nothing changes.

The underlying reason is because the hash doesn't change, and as a result I guess we decide there is no navigation happening. Everything works fine if the hash changes.

I understand the underlying reason, it doesn't mean it's the right UX. I believe this should be changed.

Comment 1

[Marcos Caceres [:marcosc]]

Agree, that's broken.

Comment 2

[Marcos Caceres [:marcosc]]

Interesting, Chrome, Safari also don't navigate. Let's see what HTML says...
https://html.spec.whatwg.org/#scroll-to-the-fragment-identifier

So, it reads like it should navigate. But I can't quite decipher what it's says there.

Comment 3

[Anne (:annevk)]

This works fine at https://wiki.whatwg.org/wiki/FAQ#The_WHATWG so I think the problem is that GitHub is implementing its own navigation in JavaScript and hasn't accounted for this scenario. I recommend reporting an issue to GitHub.

Comment 4

[Andrew Overholt [:overholt]]

So should we close this?

Comment 5

[Julien Wajsberg [:julienw]]

Yes, I think so.

Thanks a lot for the debugging, sorry for wasting your time.
I'll report this back to Github.