[Fennec Relpro] Prevent old-release-runner to pick up Fennec betas

RESOLVED FIXED

Status

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Up until now, ship-it triggers some buildbot jobs when we want to release Fennec beta/release.

Once bug 1338161 is done, we should redirect the builds to release-runner.
Assignee

Updated

2 years ago
Assignee: nobody → jlorenzo
Assignee

Comment 2

2 years ago
Comment on attachment 8839149 [details]
Bug 1340548 - [Fennec Relpro] Prevent betas from being handled by buildbot (aka old release runner)

Based on the IRC discussion we had last Friday, we should just modify old-release-runner. The latest release-runner has actually been done in bug 1338150.

I just took out beta builds. Release will have to wait 6 more weeks.

I also cleaned up the comments. After checking out bug 1252333 and bug 1263976, I'm not sure we actually need to backout these bugs. Once relpro is done, we should just stop using old-release-runner, is that correct? If not please tell me I'm living a lie :) 

What do you think Mihai?
Attachment #8839149 - Flags: review?(mtabara)
Assignee

Updated

2 years ago
Depends on: 1338150
See Also: → 1252333, 1263976
Assignee

Updated

2 years ago
Summary: [Fennec Relpro] Let ship-it give a Fennec release to Release-Runner → [Fennec Relpro] Prevent old-release-runner to pick up Fennec betas

Comment 3

2 years ago
mozreview-review
Comment on attachment 8839149 [details]
Bug 1340548 - [Fennec Relpro] Prevent betas from being handled by buildbot (aka old release runner)

https://reviewboard.mozilla.org/r/113872/#review115416

::: buildfarm/release/release-runner.py:38
(Diff revision 1)
>  
>  log = logging.getLogger(__name__)
>  
>  
> -# temporary regex to filter out firefox desktop beta, release and dot release
> +# temporary regex to filter out Firefox Desktop and Fennec betas
>  # as they're handled separately within release promotion. Once migration to

We can drop this comment sentence "Once migration .." I doubt we'll ever remove this regex. When we do, it means we found a solution for Thunderbird so hopefully we can kill this entire branch altogether :)

::: buildfarm/release/release-runner.py:39
(Diff revision 1)
>  log = logging.getLogger(__name__)
>  
>  
> -# temporary regex to filter out firefox desktop beta, release and dot release
> +# temporary regex to filter out Firefox Desktop and Fennec betas
>  # as they're handled separately within release promotion. Once migration to
> -# promotion is completed for all types of releases, we will backout this
> +# promotion is completed for all types of releases.

+1 on filtering just betas. We definitely want the Fennec betas *only* as there might be a Fennec dot release in those 6 weeks that we wouldn't want to deal with in relpro. Once we're ready for a Fennec release, we can follow-up to remove this too.
Attachment #8839149 - Flags: review?(mtabara) → review+
(In reply to Johan Lorenzo [:jlorenzo] from comment #2)
> Comment on attachment 8839149 [details]
> I just took out beta builds. Release will have to wait 6 more weeks.

+1 good catch! We wouldn't want to deal with a surprise dot-release Fennec while we still heavily work on Fennec beta. 
 
> I also cleaned up the comments. After checking out bug 1252333 and bug
> 1263976, I'm not sure we actually need to backout these bugs. Once relpro is
> done, we should just stop using old-release-runner, is that correct? If not
> please tell me I'm living a lie :) 

++ definitely won't need to backout those changes, we're far too much into progress to come back to the past! :P
However, until we find a solution for Thunderbird, I'm afraid we can't delete the 'old-release-runner' branch even though we have all the other stuff in relpro.

Updated

2 years ago
Priority: -- → P1
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Assignee

Comment 6

2 years ago
Comments in code updated per Mihai's review.

Today is merge day, and we'll be willing to use Release promotion for beta. I checked with :jcristau whether an unexpected Fennec 52.0b12 may come up today. He confirmed, there won't be any.

Hence, I landed the patch on the old-release-runner branch at: https://hg.mozilla.org/build/tools/rev/172a81d0d5abad9f9bdf5858dd4dd8052637532b
Assignee

Comment 7

2 years ago
I didn't find the documentation for deploying old-release-runner. A simple `puppet apply --test` didn't update the repo. That's why, I went with Mihai's suggestion: manually update the repo, and `supervisorctl restart releaserunner`.

Thank you for the help, Mihai!
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.