[swift-3-regression] pagecontrol button for top Sites field appears on the wrong field

VERIFIED FIXED

Status

()

Firefox for iOS
Home screen
P2
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: njpark, Assigned: bkmunar)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

(Whiteboard: [mobileAS])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Found when running XCUITests/ActivityStreamTest.swift.

The top sites table does not show the page control button within the top sites field- it sits within the below field next to the 'Be on the Lookout' text.  When XCUITest tries to tap the button, it fails with the following error:

 Assertion Failure: ActivityStreamTest.swift:108: UI Testing Failure - Unable to find hit point for Button 0x60000036a140: traits: 8589934593, {{172.5, 401.0}, {30.0, 15.0}}, identifier: 'pageControl', label: 'Next Page'
(Reporter)

Updated

a year ago
No longer depends on: 1339678
(Reporter)

Comment 1

a year ago
Created attachment 8838664 [details]
Screen Shot 2017-02-17 at 2.08.02 PM.png
tracking-fxios: --- → ?
tracking-fxios: ? → 8.0+
Whiteboard: [mobileAS]
Priority: -- → P2
(Assignee)

Comment 2

a year ago
Created attachment 8844656 [details] [review]
PR
Attachment #8844656 - Flags: review?(fpatel)
Attachment #8844656 - Flags: review?(fpatel) → review+
(Assignee)

Comment 3

a year ago
https://github.com/mozilla-mobile/firefox-ios/pull/2500/commits/fcb88548a6433c9ce64b2f04e60dfe99130519c5
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Assignee: nobody → bmunar
Verified. The automated test already passes. Now that button is visible and it is possible to tap on it. Thanks!
Status: RESOLVED → VERIFIED
See Also: → bug 1351717
You need to log in before you can comment on or make changes to this bug.