Closed Bug 1340631 Opened 3 years ago Closed 3 years ago

TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/unit/test_crashreporter_crash.js

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 54.0

People

(Reporter: jorgk-bmo, Assigned: gsvelto)

References

Details

(Keywords: intermittent-failure, Whiteboard: [Thunderbird-testfailure: X all debug])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/unit/test_crashreporter_crash.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/crashreporter/test/unit/test_crashreporter_crash.js | run_test/< - [run_test/< : 49] The TelemetryServerURL field is omitted when telemetry is off - false == true

First seen Tue Feb 14, 2017, 23:43:23:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a7db0899f6a4eb581aca3e63668823a416111503

M-C last good: 47391e531350873bfccd576b689259ec24
M-C first bad: 1060668405a9399774c205430de4a7001d

Range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47391e531350873bfccd576b689259ec24&tochange=1060668405a9399774c205430de4a7001d

Suspect bug 1310703.

Gabriele and Alessio: Any idea why this test would fail in a TB debug build? It works in an opt build.
Flags: needinfo?(gsvelto)
Flags: needinfo?(alessio.placitelli)
It's an issue with the tests I've introduced in bug 1310703, I've got a trivial fix ready so I'll land it after I get a successful try run.
Flags: needinfo?(gsvelto)
Flags: needinfo?(alessio.placitelli)
BTW it shouldn't be intermittent, it should be permanent.
Try run with the fix applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b344aa9399e81ff688749b45be7c54c66403931
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Thanks for your comments and the patch. It is a permanent failure, but we need to put the keyword "intermittent-failure" so the treeherder software will offer the bug for starring (adding a star with a reference to the bug).
OK, I'm stumped, it really is intermittent, if I reverse the condition - which is the right test - it still fails sometimes. I'll revert it and file a bug to write a new test and ensure that this one isn't failing intermittently.
Depends on: 1310703
Ted, this is making our Thunderbird tree red (amongst other things), can you please review, it's been waiting for a week now.
Flags: needinfo?(ted)
Comment on attachment 8839689 [details]
Bug 1340631 - Remove the telemetry-related crash annotation tests

https://reviewboard.mozilla.org/r/114266/#review117850

Did you file a followup bug to write a better test? Also: this failing in Thunderbird might just be due to some parts of Telemetry not being enabled there, but I'm not totally sure.
Attachment #8839689 - Flags: review?(ted) → review+
Flags: needinfo?(ted)
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #8)
> Did you file a followup bug to write a better test?

Kinda because as it turns out I was making this conditional on the toolkit.telemetry.enabled pref while I should have used datareporting.healthreport.uploadEnabled instead. So I've filed bug 1341349 to fix it and I'll add back the test.

> Also: this failing in
> Thunderbird might just be due to some parts of Telemetry not being enabled
> there, but I'm not totally sure.

I will double-check the issue and I'll make sure it works on comm-central too before re-landing, I might just disable the test if it doesn't make sense there.
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b73f06be7ce6
Remove the telemetry-related crash annotation tests r=Ted
https://hg.mozilla.org/mozilla-central/rev/b73f06be7ce6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
You need to log in before you can comment on or make changes to this bug.