1340642 - "Ship it" button no longer grants r+ (yes it's hidden by default, but it's still showable via devtools or Stylish & used to work)

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. View a review request in MozReview.
 2. Using either devtools or a Stylish CSS rule, disable the "display:none" rule on #shipit-link.
 3. Click "Ship it" to try to grant r+ on the review.
 4. Click "OK" on the "are you sure" dialog that appears.

EXPECTED RESULTS:
 review+ should be granted.

ACTUAL RESULTS:
 A bugzilla comment gets posted, but review+ is not granted.

I just ran into this in bug 775624 comment 40 -- note that (unlike prior comments there where I had used the longer review process in MozReview), there's no "-> review+" at the bottom of that comment.

I know we hide the Ship It button by default, but it'd be great if we could keep it working for reviewers who want to use it (who make it show up manually).  Bug 775624 is a case where it's a super-handy workflow, to save a little bit of time on each likely-correct-with-no-review-comments part of a many-part patch series.


NOTE: For reference/easier testing, here's a rule for the Stylish add-on that will automatically make this button show up (step 2 of my STR):
@namespace url(http://www.w3.org/1999/xhtml);
@-moz-document domain("reviewboard.mozilla.org") {
  #shipit-link { display: block !important; }
}

Comment 1

[:glob ✱]

sorry, but we cannot address breakage caused by overriding the visibility of elements that should not be visible.

please file a bug for the workflow issue; it isn't clear here exactly what it is that you're trying to address.