Closed Bug 1340665 Opened 3 years ago Closed 3 years ago

24,400 instances of "'!mMainThread'" emitted from xpcom/threads/nsThreadManager.cpp during linux64 debug testing

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla55

Tracking Flags:

Tracking

Status

firefox55

---

fixed

People

(Reporter: erahm, Assigned: mrbkap)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1340665 - Fix warnings on shutdown. 3 years ago Blake Kaplan (:mrbkap) (inactive, use needinfo) 59 bytes, text/x-review-board-request	billm : review+	Details

Eric Rahm [:erahm]

Reporter

Description

•

3 years ago

> 24406 WARNING: '!mMainThread', file xpcom/threads/nsThreadManager.cpp, line 314

This warning [1] shows up in the following test suites:

>   1513 - test-linux64/debug-mochitest-chrome-1 c1
>   1128 - test-linux64/debug-mochitest-chrome-3 c3
>   1000 - test-linux64/debug-mochitest-2 2
>    961 - test-linux64/debug-mochitest-clipboard-e10s cl
>    720 - test-linux64/debug-mochitest-e10s-10 10
>    680 - test-linux64/debug-mochitest-chrome-2 c2
>    640 - test-linux64/debug-mochitest-clipboard cl
>    600 - test-linux64/debug-mochitest-e10s-5 5
>    544 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>    536 - test-linux64/debug-mochitest-4 4
>    536 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>    512 - test-linux64/debug-mochitest-e10s-6 6
>    488 - test-linux64/debug-mochitest-e10s-1 1
>    472 - test-linux64/debug-mochitest-e10s-7 7
>    464 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>    464 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>    456 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>    448 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>    448 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>    432 - test-linux64/debug-mochitest-e10s-8 8
>    416 - test-linux64/debug-mochitest-e10s-9 9
>    408 - test-linux64/debug-mochitest-e10s-4 4
>    392 - test-linux64/debug-mochitest-e10s-2 2
>    384 - test-linux64/debug-mochitest-e10s-3 3
>    384 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>    376 - test-linux64/debug-mochitest-10 10
>    344 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>    304 - test-linux64/debug-mochitest-8 8
>    304 - test-linux64/debug-mochitest-5 5
>    296 - test-linux64/debug-mochitest-1 1
>    280 - test-linux64/debug-mochitest-3 3
>    272 - test-linux64/debug-mochitest-6 6
>    272 - test-linux64/debug-mochitest-7 7
>    256 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>    256 - test-linux64/debug-mochitest-browser-chrome-7 bc7
>    256 - test-linux64/debug-mochitest-browser-chrome-5 bc5
>    248 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>    248 - test-linux64/debug-mochitest-9 9
>    240 - test-linux64/debug-mochitest-browser-chrome-3 bc3
>    224 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>    224 - test-linux64/debug-mochitest-browser-chrome-6 bc6
>    224 - test-linux64/debug-mochitest-browser-chrome-4 bc4
>    224 - test-linux64/debug-mochitest-browser-chrome-2 bc2
>    208 - test-linux64/debug-mochitest-browser-chrome-1 bc1
>    208 - test-linux64/debug-mochitest-gpu-e10s gpu
>    176 - test-linux64/debug-mochitest-jetpack JP
>    168 - test-linux64/debug-mochitest-devtools-chrome-7 dt7
>    160 - test-linux64/debug-mochitest-media-e10s-3 mda3
>    160 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>    160 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>    128 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>    128 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>    128 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>    112 - test-linux64/debug-firefox-ui-functional-local en-US
>    112 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>     96 - test-linux64/debug-mochitest-media-3 mda3
>     80 - test-linux64/debug-mochitest-devtools-chrome-6 dt6
>     80 - test-linux64/debug-mochitest-devtools-chrome-1 dt1
>     80 - test-linux64/debug-mochitest-devtools-chrome-5 dt5
>     74 - test-linux64/debug-mochitest-media-e10s-2 mda2
>     64 - test-linux64/debug-mochitest-webgl-3 gl3
>     64 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>     64 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>     64 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>     64 - test-linux64/debug-mochitest-devtools-chrome-9 dt9
>     64 - test-linux64/debug-mochitest-devtools-chrome-2 dt2
>     56 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>     50 - test-linux64/debug-mochitest-media-2 mda2
>     48 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>     48 - test-linux64/debug-firefox-ui-functional-remote en-US
>     48 - test-linux64/debug-mochitest-a11y a11y
>     48 - test-linux64/debug-mochitest-devtools-chrome-3 dt3
>     48 - test-linux64/debug-mochitest-media-e10s-1 mda1
>     40 - test-linux64/debug-reftest-e10s-7 R7
>     40 - test-linux64/debug-reftest-e10s-8 R8
>     40 - test-linux64/debug-reftest-e10s-2 R2
>     40 - test-linux64/debug-reftest-e10s-5 R5
>     40 - test-linux64/debug-jsreftest-e10s-3 J3
>     40 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>     40 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>     40 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>     40 - test-linux64/debug-jsreftest-e10s-2 J2
>     40 - test-linux64/debug-jsreftest-e10s-1 J1
>     40 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>     40 - test-linux64/debug-reftest-e10s-6 R6
>     40 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>     40 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>     40 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>     40 - test-linux64/debug-reftest-e10s-3 R3
>     40 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>     40 - test-linux64/debug-reftest-e10s-4 R4
>     40 - test-linux64/debug-reftest-e10s-1 R1
>     40 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>     40 - test-linux64/debug-crashtest-e10s C
>     32 - test-linux64/debug-mochitest-devtools-chrome-4 dt4
>     32 - test-linux64/debug-mochitest-webgl-1 gl1
>     32 - test-linux64/debug-mochitest-media-1 mda1
>     32 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
>     32 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
>     32 - test-linux64/debug-mochitest-devtools-chrome-8 dt8
>     24 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>     16 - test-linux64/debug-reftest-2 R2
>     16 - test-linux64/debug-reftest-no-accel-4 Ru4
>     16 - test-linux64/debug-reftest-no-accel-6 Ru6
>     16 - test-linux64/debug-reftest-1 R1
>     16 - test-linux64/debug-reftest-no-accel-3 Ru3
>     16 - test-linux64/debug-mochitest-browser-chrome-11 bc11
>     16 - test-linux64/debug-reftest-no-accel-5 Ru5
>     16 - test-linux64/debug-reftest-no-accel-1 Ru1
>     16 - test-linux64/debug-reftest-no-accel-2 Ru2
>     16 - Static Checking Build S
>     16 - test-linux64/debug-mochitest-browser-chrome-10 bc10
>     16 - test-linux64/debug-crashtest C
>     16 - test-linux64/debug-reftest-7 R7
>     16 - test-linux64/debug-reftest-no-accel-8 Ru8
>     16 - test-linux64/debug-jsreftest-3 J3
>     16 - test-linux64/debug-reftest-no-accel-7 Ru7
>     16 - test-linux64/debug-reftest-3 R3
>     16 - test-linux64/debug-mochitest-devtools-chrome-10 dt10
>     16 - test-linux64/debug-reftest-4 R4
>     16 - test-linux64/debug-mochitest-browser-chrome-8 bc8
>     16 - test-linux64/debug-reftest-6 R6
>     16 - test-linux64/debug-jsreftest-1 J1
>     16 - test-linux64/debug-mochitest-browser-chrome-12 bc12
>     16 - build-linux64/debug B
>     16 - test-linux64/debug-reftest-8 R8
>     16 - test-linux64/debug-jsreftest-2 J2
>     16 - test-linux64/debug-mochitest-browser-chrome-9 bc9
>     16 - test-linux64/debug-reftest-5 R5
>     16 - test-linux64/debug-mochitest-webgl-2 gl2
>      8 - test-linux64/debug-gtest GTest

It shows up in 196 tests. A few of the most prevalent:

>  10827 - [e10s] Shutdown
>   8698 -        Shutdown
>    152 - [e10s] dom/tests/browser/browser_largeAllocation_non_win32.js
>    144 -        jetpack-package/addon-sdk/source/test/test-simple-prefs.js.testUnloadOfDynamicPrefGeneration
>    128 -        dom/base/test/chrome/test_swapFrameLoaders.xul
>    112 -        test_restore_windows_after_restart.py TestRestoreWindowsAfterRestart.test_with_variety
>     80 - [e10s] test_windows.py TestBrowserWindow.test_open_close
>     64 - [e10s] test_safe_browsing_notification.py TestSafeBrowsingNotificationBar.test_notification_bar
>     56 - [e10s] dom/security/test/mixedcontentblocker/test_bug803225.html
>     56 - [e10s] jetpack-package/addon-sdk/source/test/test-clipboard.js.test With Redundant Flavor

[1] https://hg.mozilla.org/mozilla-central/annotate/df9a0acc2648/xpcom/threads/nsThreadManager.cpp#l314

Eric Rahm [:erahm]

Reporter

Comment 1

•

3 years ago

Bill, bisection points to bug 1337537, bug 1337577, bug 1337575, bug 1334572, or bug 1334346:

> 6:08.10 INFO: Last good revision: 652c909b75ad19af508537f71f82dd8cc2fa6e70
> 6:08.10 INFO: First bad revision: 6fe6f63a39f1ef3ad8a54ba4ee06e24fce10e8af
> 6:08.10 INFO: Pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=652c909b75ad19af508537f71f82dd8cc2fa6e70&tochange=6fe6f63a39f1ef3ad8a54ba4ee06e24fce10e8af

Flags: needinfo?(wmccloskey)

Comment hidden (mozreview-request)

The code to make a ValidatingDispatcher break cycles when we're done with it
assumes that XPCOM is still up and running. This isn't the case during
shutdown. When XPCOM shuts down, we should avoid do_GetMainThread.

Review commit: https://reviewboard.mozilla.org/r/119318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119318/

Blake Kaplan (:mrbkap) (inactive, use needinfo)

Assignee

Updated

•

3 years ago

Assignee: nobody → mrbkap

Bill McCloskey [inactive unless it's an emergency] (:billm)

Comment 3

•

3 years ago

mozreview-review

Comment on attachment 8846218 [details]
Bug 1340665 - Fix warnings on shutdown.

https://reviewboard.mozilla.org/r/119318/#review121658

Attachment #8846218 - Flags: review?(wmccloskey) → review+

Bill McCloskey [inactive unless it's an emergency] (:billm)

Comment 4

•

3 years ago

Sorry I never got to this. I had a patch and then realized it wouldn't work, and then I forgot about it.

Flags: needinfo?(wmccloskey)

Pulsebot

Comment 5

•

3 years ago

Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86d53419eab7
Fix warnings on shutdown. r=billm

Carsten Book [:Tomcat]

Comment 6

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/86d53419eab7

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox55: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla55

Nobody; OK to take it and work on it

Updated

•

5 months ago

Component: DOM → DOM: Core & HTML

You need to log in before you can comment on or make changes to this bug.

Bugzilla

24,400 instances of "'!mMainThread'" emitted from xpcom/threads/nsThreadManager.cpp during linux64 debug testing

Categories

(Core :: DOM: Core & HTML, defect)

Tracking

()

People

(Reporter: erahm, Assigned: mrbkap)

References

(Blocks 1 open bug)

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Updated

Comment 3

Comment 4

Comment 5

Comment 6

Updated