1340671 - [webext] Fix race in getDevToolsTargetForContext utility method

Status: RESOLVED FIXED

(WebExtensions :: Developer Tools, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

`getDevToolsTargetForContext` returns a promise that is supposed to be resolved once the returned "cloned DevTools target" has been connected.

Currently, if a devtools API method that use `getDevToolsTargetForContext` utility method (e.g. `inspectedWindow.eval/reload` and `network.onNavigated`) is called while the cloned target (shared between the devtools API called from the same context) is still connecting, the second call can receive the clonedTarget before it is ready to be used (while it should wait for the `target.makeRemote()` promise to be resolved, http://searchfox.org/mozilla-central/rev/ea31c4b64f34a29415a69fb768f8051495547315/devtools/client/framework/target.js#381).

I'm going to attach to this issue a patch to fix the race.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1340671 - [webext] Fix race in getDevToolsTargetForContext utility method.

Review commit: https://reviewboard.mozilla.org/r/113534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113534/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8838726 [details]
Bug 1340671 - [webext] Fix race in getDevToolsTargetForContext utility method.

https://reviewboard.mozilla.org/r/113534/#review118888

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be448fec2032
[webext] Fix race in getDevToolsTargetForContext utility method. r=kmag

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be448fec2032