1340677 - Stop supporting ORIGIN_IS_FULL_SPEC for Firefox

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[(no longer active)]

The check that we do for this flag in NS_SecurityCompareURIs sometimes shows up in profiles.  This flag was added only for Thunderbird and the Mozilla suite and was never used in mozilla-central, so we are just paying its performance cost.  We should remove this from Firefox and only use it for those other products.

Comment 1

[(no longer active)]

Attachment: Stop supporting ORIGIN_IS_FULL_SPEC for Firefox

This is only used in Thunderbird and SeaMonkey and makes origin
comparisons needlessly slow in Firefox.

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8838735 [details] [diff] [review]
Stop supporting ORIGIN_IS_FULL_SPEC for Firefox

Review of attachment 8838735 [details] [diff] [review]:
-----------------------------------------------------------------

awesome. thanks!

::: netwerk/base/nsIProtocolHandler.idl
@@ +304,2 @@
>       */
>      const unsigned long ORIGIN_IS_FULL_SPEC = (1 << 20);

I think you should ifdef this one too - so any addon users or whatever will get an exception and notice

Comment 3

[Honza Bambas (:mayhemer)]

(In reply to :Ehsan Akhgari from comment #0)
> The check that we do for this flag in NS_SecurityCompareURIs sometimes shows
> up in profiles.  This flag was added only for Thunderbird and the Mozilla
> suite and was never used in mozilla-central, so we are just paying its
> performance cost.  We should remove this from Firefox and only use it for
> those other products.

Ehsan, if you are removing this check on non-comm-cental then we MUST MOZ_CRASH when we find a protocol that defines that flag on non-comm-cental.  Don't you think?

Comment 4

[(no longer active)]

(In reply to Patrick McManus [:mcmanus] from comment #2)
> ::: netwerk/base/nsIProtocolHandler.idl
> @@ +304,2 @@
> >       */
> >      const unsigned long ORIGIN_IS_FULL_SPEC = (1 << 20);
> 
> I think you should ifdef this one too - so any addon users or whatever will
> get an exception and notice

Unfortunately it's not possible to preprocess XPIDL files...  That being said I did check and no extension are using this thankfully.

(In reply to Honza Bambas (:mayhemer) from comment #3)
> Ehsan, if you are removing this check on non-comm-cental then we MUST
> MOZ_CRASH when we find a protocol that defines that flag on non-comm-cental.
> Don't you think?

Sure, that's a good idea.  Will do.

Comment 5

[(no longer active)]

Attachment: Stop supporting ORIGIN_IS_FULL_SPEC for Firefox

This is only used in Thunderbird and SeaMonkey and makes origin
comparisons needlessly slow in Firefox.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3699678d46e
Stop supporting ORIGIN_IS_FULL_SPEC for Firefox; r=mcmanus

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e3699678d46e