Support unicode characters in paths for install manifests

NEW
Unassigned

Status

2 years ago
a year ago

People

(Reporter: mshal, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
We have a Makefile.in that installs some files in a directory with a unicode character: https://dxr.mozilla.org/mozilla-central/rev/0eef1d5a39366059677c6d7944cfe8a97265a011/toolkit/mozapps/update/tests/Makefile.in#28

I'd like to port this to moz.build with something like this:

if CONFIG['OS_ARCH'] == 'WINNT':
    # TestAUSReadStrings runs during check in the following directory with a
    # Unicode char in order to test bug 473417 on Windows.
#    bug473417dir = u'test_bug473417-ó'
    bug473417dir = u'test_bug473417-\u00F3'
else:
    bug473417dir = 'test_bug473417'

TEST_HARNESS_FILES.xpcshell.toolkit.mozapps.update.tests.data[bug473417dir] += [
    '!TestAUSReadStrings%s' % CONFIG['BIN_SUFFIX'],
    'TestAUSReadStrings1.ini',
    'TestAUSReadStrings2.ini',
    'TestAUSReadStrings3.ini',
]
(Reporter)

Comment 1

2 years ago
We have an alternate solution for bug 1340699, so this is no longer blocking other work. However, it would still be nice to have if we upgrade to python3 someday. The unicode support in python2 does not seem to lend itself to an easy fix here.
No longer blocks: 1340699

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.