1340733 - get 'attributes' from xpcom accessible hangs the browser in windows.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Bug 1339951 fixes some deadlocks that could occur in content. We should retest this after that bug merges into central.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1340733 - Fix attributes getter in win/ProxyAccessible.

Review commit: https://reviewboard.mozilla.org/r/113612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113612/

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Aaron Klotz [:aklotz] from comment #1)
> Bug 1339951 fixes some deadlocks that could occur in content. We should
> retest this after that bug merges into central.

This was more of an infinite loop issue..

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Fair enough...

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8838792 [details]
Bug 1340733 - Fix attributes getter in win/ProxyAccessible.

https://reviewboard.mozilla.org/r/113612/#review115204

Thanks! Just 1 comment.

::: accessible/tests/browser/e10s/browser.ini:2
(Diff revision 1)
>  [DEFAULT]
> +skip-if = e10s && os == 'win' && os_version == '5.1'

Thanks for cleaning this up. FYI, we do not run these tests on XP any more so I think it should be safe to drop this skip-if entirely.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8838792 [details]
Bug 1340733 - Fix attributes getter in win/ProxyAccessible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/113612/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb9e42d09099
Fix attributes getter in win/ProxyAccessible. r=yzen

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb9e42d09099