Closed Bug 1340735 Opened 3 years ago Closed 3 years ago

Terminate process when failing to attach it to job group

Categories

(Toolkit :: Async Tooling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox51 --- wontfix
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

This can cause stale processes to hang around when security software prevents us from attaching them to a job group.
Comment on attachment 8838786 [details]
Bug 1340735 - Terminate process when failing to attach it to job group.

https://reviewboard.mozilla.org/r/113594/#review115182
Attachment #8838786 - Flags: review?(mhowell) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/acf9b36c79170b23803d354a7fae1f89033b3e04
Bug 1340735 - Terminate process when failing to attach it to job group. r=mhowell
https://hg.mozilla.org/mozilla-central/rev/acf9b36c7917
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment on attachment 8838786 [details]
Bug 1340735 - Terminate process when failing to attach it to job group.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1290598
[User impact if declined]: This issue can cause extra processes spawned by add-ons to remain running when security software prevents them from being attached to a job group.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: Installing an affected version of Norton security software on Windows XP, per bug 1334503, would suffice. But that issue has already been fixed, and this issue is hard to reproduce in isolation.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Very low risk.
[Why is the change risky/not risky?]: This change only has an effect in a particular error case which is otherwise handled incorrectly. The fix itself is trivial.
[String changes made/needed]: None.
Attachment #8838786 - Flags: approval-mozilla-beta?
Attachment #8838786 - Flags: approval-mozilla-aurora?
Comment on attachment 8838786 [details]
Bug 1340735 - Terminate process when failing to attach it to job group.

don't leak processes in error case, beta52+, aurora53+

Should be in 52.0b9
Attachment #8838786 - Flags: approval-mozilla-beta?
Attachment #8838786 - Flags: approval-mozilla-beta+
Attachment #8838786 - Flags: approval-mozilla-aurora?
Attachment #8838786 - Flags: approval-mozilla-aurora+
Setting qe-verify- based on Kris' assessment on manual testing needs (see Comment 5) and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.