don't use weak frames for reflow callbacks in nsProgressMeterFrame

RESOLVED WONTFIX

Status

()

Core
Layout: Misc Code
RESOLVED WONTFIX
a year ago
a year ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox54 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Same reasoning as bug 1340452 and bug 1340451. This one isn't used for selects though. This was the only other use of weakframes for reflowcallback only. There are other weakframe usage for async events. Maybe we should change the data structure for weak frames.
(Assignee)

Comment 1

a year ago
Created attachment 8838803 [details] [diff] [review]
patch
Attachment #8838803 - Flags: review?(mats)
> Maybe we should change the data structure for weak frames

Yeah, that might be better actually.  Then we could potentially use
script runners for some of these things rather than reflow callbacks.

In this particular case, I'm not sure if it's worth changing since it
likely can't be reached from web content.  I doubt we create that many
of these frames in our UI that it matters for performance.
(Assignee)

Updated

a year ago
Attachment #8838803 - Flags: review?(mats)
(Assignee)

Comment 3

a year ago
Okay, I'll mark this wont fix and file a bug about changing how weak frames work.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
(Assignee)

Comment 4

a year ago
Filed bug 1340771 for better weak frame data structure.
You need to log in before you can comment on or make changes to this bug.