Closed
Bug 1340745
Opened 7 years ago
Closed 7 years ago
don't use weak frames for reflow callbacks in nsProgressMeterFrame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox54 | --- | affected |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
4.03 KB,
patch
|
Details | Diff | Splinter Review |
Same reasoning as bug 1340452 and bug 1340451. This one isn't used for selects though. This was the only other use of weakframes for reflowcallback only. There are other weakframe usage for async events. Maybe we should change the data structure for weak frames.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8838803 -
Flags: review?(mats)
Comment 2•7 years ago
|
||
> Maybe we should change the data structure for weak frames
Yeah, that might be better actually. Then we could potentially use
script runners for some of these things rather than reflow callbacks.
In this particular case, I'm not sure if it's worth changing since it
likely can't be reached from web content. I doubt we create that many
of these frames in our UI that it matters for performance.
Assignee | ||
Updated•7 years ago
|
Attachment #8838803 -
Flags: review?(mats)
Assignee | ||
Comment 3•7 years ago
|
||
Okay, I'll mark this wont fix and file a bug about changing how weak frames work.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 4•7 years ago
|
||
Filed bug 1340771 for better weak frame data structure.
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•