Closed Bug 1340762 Opened 3 years ago Closed 3 years ago

Move copySubmenu to its own separate function like the other submenus of context menu in inspector.js

Categories

(DevTools :: General, defect, P3)

51 Branch
x86_64
Linux
defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: djmdeveloper060796, Assigned: djmdeveloper060796)

References

Details

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170201180315




Expected results:

Presently in /devtools/client/inspector.js,  the attributes submenu and paste submenu are created in separate functions and those functions are called in _openMenu function inorder to create the submenus, but copy submenu is created within the _openMenu function.It would be nice to give copySubmenu its own separate function like the other two. It will reduce the size of the _openMenu function as well as will make the code more consistent.
OS: Unspecified → Linux
Hardware: Unspecified → x86
Component: Untriaged → Developer Tools
Hardware: x86 → x86_64
Attached patch bug1340762.patch (obsolete) — Splinter Review
Moved copySubmenu to a separate function
See Also: → 1231932
Flags: a11y-review?
Flags: a11y-review?
Attached patch bug1340762.patch (obsolete) — Splinter Review
Moved copySubmenu to separate function
Attachment #8838829 - Attachment is obsolete: true
Attachment #8838831 - Flags: review?(gl)
Assignee: nobody → djmdeveloper060796
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Attached patch bug1340762.patchSplinter Review
rebased and r+. Thank you for the patch Deepjyoti
Attachment #8838897 - Flags: review+
Attachment #8838831 - Attachment is obsolete: true
Attachment #8838831 - Flags: review?(gl)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d805983cf3
Refactor copySubmenu into its own separate function in inspector.js; r=gl
Flags: qe-verify-
https://hg.mozilla.org/mozilla-central/rev/c0d805983cf3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.