Move copySubmenu to its own separate function like the other submenus of context menu in inspector.js

RESOLVED FIXED in Firefox 54

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Deepjyoti Mondal, Assigned: Deepjyoti Mondal)

Tracking

51 Branch
Firefox 54
x86_64
Linux
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 months ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170201180315




Expected results:

Presently in /devtools/client/inspector.js,  the attributes submenu and paste submenu are created in separate functions and those functions are called in _openMenu function inorder to create the submenus, but copy submenu is created within the _openMenu function.It would be nice to give copySubmenu its own separate function like the other two. It will reduce the size of the _openMenu function as well as will make the code more consistent.
(Assignee)

Updated

8 months ago
OS: Unspecified → Linux
Hardware: Unspecified → x86
(Assignee)

Updated

8 months ago
Component: Untriaged → Developer Tools
Hardware: x86 → x86_64
(Assignee)

Comment 1

8 months ago
Created attachment 8838829 [details] [diff] [review]
bug1340762.patch

Moved copySubmenu to a separate function
(Assignee)

Updated

8 months ago
See Also: → bug 1231932
(Assignee)

Updated

8 months ago
Flags: a11y-review?
(Assignee)

Updated

8 months ago
Flags: a11y-review?
(Assignee)

Comment 2

8 months ago
Created attachment 8838831 [details] [diff] [review]
bug1340762.patch

Moved copySubmenu to separate function
Attachment #8838829 - Attachment is obsolete: true
Attachment #8838831 - Flags: review?(gl)

Updated

8 months ago
Assignee: nobody → djmdeveloper060796
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Created attachment 8838897 [details] [diff] [review]
bug1340762.patch

rebased and r+. Thank you for the patch Deepjyoti
Attachment #8838897 - Flags: review+

Updated

8 months ago
Attachment #8838831 - Attachment is obsolete: true
Attachment #8838831 - Flags: review?(gl)

Comment 4

8 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d805983cf3
Refactor copySubmenu into its own separate function in inspector.js; r=gl

Updated

8 months ago
Flags: qe-verify-

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c0d805983cf3
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.