Closed
Bug 1340762
Opened 7 years ago
Closed 7 years ago
Move copySubmenu to its own separate function like the other submenus of context menu in inspector.js
Categories
(DevTools :: General, defect, P3)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: djmdeveloper060796, Assigned: djmdeveloper060796)
References
Details
Attachments
(1 file, 2 obsolete files)
5.16 KB,
patch
|
gl
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 Build ID: 20170201180315 Expected results: Presently in /devtools/client/inspector.js, the attributes submenu and paste submenu are created in separate functions and those functions are called in _openMenu function inorder to create the submenus, but copy submenu is created within the _openMenu function.It would be nice to give copySubmenu its own separate function like the other two. It will reduce the size of the _openMenu function as well as will make the code more consistent.
Assignee | ||
Updated•7 years ago
|
OS: Unspecified → Linux
Hardware: Unspecified → x86
Assignee | ||
Updated•7 years ago
|
Component: Untriaged → Developer Tools
Hardware: x86 → x86_64
Assignee | ||
Comment 1•7 years ago
|
||
Moved copySubmenu to a separate function
Assignee | ||
Updated•7 years ago
|
Flags: a11y-review?
Assignee | ||
Updated•7 years ago
|
Flags: a11y-review?
Assignee | ||
Comment 2•7 years ago
|
||
Moved copySubmenu to separate function
Attachment #8838829 -
Attachment is obsolete: true
Attachment #8838831 -
Flags: review?(gl)
Updated•7 years ago
|
Assignee: nobody → djmdeveloper060796
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Comment 3•7 years ago
|
||
rebased and r+. Thank you for the patch Deepjyoti
Attachment #8838897 -
Flags: review+
Updated•7 years ago
|
Attachment #8838831 -
Attachment is obsolete: true
Attachment #8838831 -
Flags: review?(gl)
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d805983cf3 Refactor copySubmenu into its own separate function in inspector.js; r=gl
Updated•7 years ago
|
Flags: qe-verify-
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c0d805983cf3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•