Open Bug 13408 Opened 20 years ago Updated 4 years ago

Deleting a read-only file creates different results on all platforms

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P2, major)

Tracking

(Not tracked)

People

(Reporter: jimmykenlee, Unassigned)

Details

Build: 9/8/99 SeaMonkey build

1. From http://jimbob/trigger2.html, first trigger a_adddelcomp from the
   drop-down menu
2. From the "Program" directory, go to /delcompdir and make the file,
   deletecomponent read-only; and be sure to remove write privileges for all
   on Linux
3. From http://jimbob/trigger2.html, first trigger a_delcomp from the
drop-down menu

RESULT:
For Windows (NT and 98), the file is not deleted as expected.  However, the
Install.log shows:
---------------------------------------------------------------------------
http://jimbob/jars/a_delcomp.jar     --     09/08/1999 17:05:13
---------------------------------------------------------------------------

     Acceptance: a_adddelcomp


     ** DeleteComponent returns = 0
     Item [2/1]	Deleting component: acceptance/a_adddelcomp

     Install completed successfully, restart required
     Finished Installation  09/08/1999 17:05:13

For Linux, the file is deleted unexpectedly.  The Install.log shows:

---------------------------------------------------------------------------
http://jimbob/jars/a_delcomp.jar    --     09/08/1999  17:15:33
---------------------------------------------------------------------------

     Acceptance: a_adddelcomp


     ** DeleteComponent returns = 0
     Item [2/1]	Deleting component: acceptance/a_adddelcomp

     Install completed successfully
     Finished Installation  09/08/1999 17:15:33

For Macintosh, the file is not deleted as expected.  The Install.log shows:

---------------------------------------------------------------------------
http://jimbob/jars/a_delcomp.jar    --     09/08/1999  17:27:45
---------------------------------------------------------------------------

     Acceptance: a_adddelcomp


     ** DeleteComponent returns = 18

     Install script aborted
     Finished Installation  09/08/1999 17:27:47

In all cases, the version registry

EXPECTED RESULT:
The file on Linux should not have been deleted.  From Macintosh, the error 18 is
not a currently published XPInstall error code, so we should actually return a
known one.  For Windows, the log file should not indicate a successful
installation.  And certainly, restarting apprunner does not resolve the problem.
We should be returning an error message of some sort.
Severity: normal → major
Oops, I didn't quite finish what I was writing.  On all platforms, the Version
Registry is updated such that the component node is removed as if a successful
deletion had taken place.  The expected result is that we don't do this since a
deletion did not actually occur.  And, it certainly does not make sense on the
Macintosh since the install script aborted.  Also, bumping up Severity to Major
due to the high degree of inconsistencies found here.
Target Milestone: M15
need to return an error when deleting a read-only file.

post-beta feature, a decision from 9/13 meeting.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine
if read only marked by users, we should be able to replace it.
but if it's marked by administrator, then we won't be able to replace it.

we need to check for file if it's read only, then we skip it.

sean will take a look at this bug.

bug meeting 3/20
Assignee: cathleen → ssu
Target Milestone: M15 → M17
push till pr3
Target Milestone: M17 → M18
Status: NEW → ASSIGNED
OS: Windows NT → All
Priority: P3 → P2
Resetting target field for missed milestones
Target Milestone: M18 → ---
over to dprice.
Assignee: ssu → dprice
Status: ASSIGNED → NEW
Target Milestone: --- → mozilla0.9.9
only nsbeta1+ bugs can have milestones, resetting to ---
Target Milestone: mozilla0.9.9 → ---
this bug should be reassigned
Assignee: dprice → nobody
QA Contact: jimmykenlee → xpi-engine
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.