Closed Bug 1340806 Opened 3 years ago Closed 3 years ago

Kill load-reps

Categories

(DevTools :: Shared Components, enhancement, P3)

enhancement

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

Details

Attachments

(1 file)

The load-reps wrapper was created to ease the transition from "reps in mozilla-central" to "reps bundled from GitHub".
It's time to remove this extra layer now that the bundle has successfully landed in m-c.
In order to be able to remove this file, all the call-sites to it must be updated (see http://searchfox.org/mozilla-central/search?q=load-reps&case=false&regexp=false&path= )
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=df100a246fe961375128e414a47071f232120a51
Assignee: nobody → jdescottes
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8838892 [details]
Bug 1340806 - stop using load-reps wrapper;

https://reviewboard.mozilla.org/r/113668/#review115234

Looks good.
I guess you didn't removed the load-reps file because reps' mochitest relies on it.
Attachment #8838892 - Flags: review?(chevobbe.nicolas) → review+
Yes exactly, I consider load-reps and reps tests to be part of the reps release.
That being said we need to remember to remove load-reps from mc next week when we update the bundle!

Try is green. Landing.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5269f2c65663
stop using load-reps wrapper;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/5269f2c65663
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.