1340835 - uninitialized variables in nsMsgSearchValidityTable::ValidateTerms

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[:aceman]

Gcc 5 thinks some variables in nsMsgSearchValidityTable::ValidateTerms() may be used uninitialized:

mailnews/base/search/src/nsMsgSearchAdapter.cpp: In member function ‘virtual nsresult nsMsgSearchValidityTable::ValidateTerms(nsIArray*)’:
mailnews/base/search/src/nsMsgSearchAdapter.cpp:840:18: warning: ‘enabled’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (!enabled || !available)
                  ^
mailnews/base/search/src/nsMsgSearchAdapter.cpp:840:18: warning: ‘available’ may be used uninitialized in this function [-Wmaybe-uninitialized]
mailnews/base/search/src/nsMsgSearchAdapter.cpp:845:13: warning: ‘validNotShown’ may be used uninitialized in this function [-Wmaybe-uninitialized]
             if (!validNotShown)
             ^

Some of the last compile warnings in mailnews. May hit us in the future when all warnings become errors.

Comment 1

[:aceman]

Attachment: patch

Do not access the variables if their setting functions failed.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=71eae703822eae0a188e39f9f96fdf3c3c04b45c

Comment 2

[Kent James (:rkent)]

Comment on attachment 8838896 [details] [diff] [review]
patch

Review of attachment 8838896 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[:aceman]

Thanks.

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/4bcbe883f3f2a5bb6f58943a30d95ba37041c934