1340845 - convert nsIArray.QueryElementAt() to do_QueryElementAt() in mailnews

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

Convert some nsIArray.QueryElementAt() occurrences to do_QueryElementAt() in mailnews C++ code. The new helper is shorter and retrieves the interface class automatically.

The pattern:
-  nsCOMPtr<nsIMsgSearchTerm> term;
-  nsresult rv = m_termList->QueryElementAt(termIndex, NS_GET_IID(nsIMsgSearchTerm),
-                                           (void **)getter_AddRefs(term));
+  nsresult rv;
+  nsCOMPtr<nsIMsgSearchTerm> term = do_QueryElementAt(m_termList, termIndex, &rv);

Comment 1

[:aceman]

Attachment: patch

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=64048ed3fa1fbaeaf1ee5820f64311f05c9b14f2

Comment 2

[Kent James (:rkent)]

Comment on attachment 8838903 [details] [diff] [review]
patch

Review of attachment 8838903 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 3

[:aceman]

Thanks.

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/56f686a5c3c0da25c08d6542149bbe66eafca5c3

Comment 5

[Jorg K (CEST = GMT+2)]

Just for the record:
https://hg.mozilla.org/comm-central/rev/56f686a5c3c0da25c08d6542149bbe66eafca5c3#l17.12

-  nsCOMPtr<nsINntpIncomingServer> nntpServer;
-  rv = server->QueryInterface(NS_GET_IID(nsINntpIncomingServer),
-                              getter_AddRefs(nntpServer));
+  nsCOMPtr<nsINntpIncomingServer> nntpServer = do_QueryInterface(server, &rv);

There are heaps more just like this one:
http://searchfox.org/comm-central/search?q=-%3EQueryInterface&case=false&regexp=false&path=
for example
http://searchfox.org/comm-central/source/mailnews/compose/src/nsMsgComposeService.cpp#958

Care to do another clean-up run?