Closed
Bug 1340856
Opened 7 years ago
Closed 7 years ago
Remove .orig file that was accidentally checked in
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
INVALID
People
(Reporter: manishearth, Assigned: manishearth)
Details
Attachments
(1 file)
I recall removing this file, but it seems to have snuck back in.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → manishearth
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8838915 [details] Bug 1340856 - Remove ServoBindingTypes.h.orig; https://reviewboard.mozilla.org/r/113684/#review115242
Attachment #8838915 -
Flags: review+
Pushed by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/87c81f278c13 Remove ServoBindingTypes.h.orig; r=KWierso
Updated•7 years ago
|
Attachment #8838915 -
Flags: review?(xidorn+moz)
Comment 4•7 years ago
|
||
It seems this was added in bug 1338936 part 3. Is there some workflow defect which can accidentally add this kind of files?
Comment 5•7 years ago
|
||
Probably we should add .orig (and some others) into .{hg,git}ignore.
Assignee | ||
Comment 6•7 years ago
|
||
> Is there some workflow defect which can accidentally add this kind of files?
Not sure how it got added, I *always* use `git add -u` (via alias) so untracked files shouldn't get added.
Comment 7•7 years ago
|
||
This got backed out together with bug 1338936: https://hg.mozilla.org/integration/autoland/rev/86affde3caa48a6a9f13aceb4927e13eabd01c2e
Flags: needinfo?(manishearth)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(manishearth)
Assignee | ||
Comment 8•7 years ago
|
||
I'll be fixing this as part of the other bug.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•