Remove .orig file that was accidentally checked in

RESOLVED INVALID

Status

()

RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: manishearth, Assigned: manishearth)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I recall removing this file, but it seems to have snuck back in.
(Assignee)

Updated

2 years ago
Assignee: nobody → manishearth
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8838915 [details]
Bug 1340856 - Remove ServoBindingTypes.h.orig;

https://reviewboard.mozilla.org/r/113684/#review115242
Attachment #8838915 - Flags: review+

Comment 3

2 years ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87c81f278c13
Remove ServoBindingTypes.h.orig; r=KWierso
Attachment #8838915 - Flags: review?(xidorn+moz)
It seems this was added in bug 1338936 part 3. Is there some workflow defect which can accidentally add this kind of files?
Probably we should add .orig (and some others) into .{hg,git}ignore.
(Assignee)

Comment 6

2 years ago
>  Is there some workflow defect which can accidentally add this kind of files?

Not sure how it got added, I *always* use `git add -u` (via alias) so untracked files shouldn't get added.
(Assignee)

Updated

2 years ago
Flags: needinfo?(manishearth)
(Assignee)

Comment 8

2 years ago
I'll be fixing this as part of the other bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.