1340858 - about:support throws error when layers.acceleration.disabled=true

Status: RESOLVED INVALID

(Toolkit :: General, defect)

Description

[Richard Marti (:Paenglab)]

With FX when layers.acceleration.disabled is on true and I open about:support I get following error in the console:
Error: WebGL warning: Failed to create WebGL context: WebGL creation failed: 
* Error during ANGLE OpenGL init.
* Error during ANGLE OpenGL init.
* Error during ANGLE OpenGL init.
* Error during ANGLE OpenGL init.
* Error during ANGLE OpenGL init.
* Exhausted GL driver caps.  Troubleshoot.jsm:448:18

and this is then shown in about:support on "WebGL 2 Renderer".

With gfx.direct2d.disabled=false "WebGL 2 Renderer" shows:
Google Inc. -- ANGLE (Intel(R) HD Graphics 3000 Direct3D11 vs_4_1 ps_4_1)

Comment 1

[Jorg K (CEST = GMT+2)]

I'm a little confused here. The summary says layers.acceleration.disabled=true and comment #0 says gfx.direct2d.disabled=false.

Using 54.0a1 (2017-02-18) (32-bit) I can confirm that with layers.acceleration.disabled=false I see
WebGL 2 Renderer	Google Inc. -- ANGLE (AMD Radeon HD 7660D Direct3D11 vs_5_0 ps_5_0)
and with layers.acceleration.disabled=true I get what is described in comment #0 coming from Troubleshoot.jsm:448:18.
Maybe that's expected.

However, when trying port FF's about:support into TB in bug 1339811, I got 
WebGL 1 Renderer	(no creation error info)
when it used to be "Google Inc. -- ANGLE (AMD Radeon HD 7660D Direct3D9Ex vs_3_0 ps_3_0)".

That's more of a concern and we'd have to take a look at the port to see where that comes from.

Comment 2

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #1)
> I'm a little confused here. The summary says
> layers.acceleration.disabled=true and comment #0 says
> gfx.direct2d.disabled=false.

Sorry, layers.acceleration.disabled=false was meant.

Comment 3

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+1) from comment #1)
> However, when trying port FF's about:support into TB in bug 1339811, I got 
> WebGL 1 Renderer	(no creation error info)
See bug 1339811 comment #16.

In FF with HWA, both WebGL 1 and WebGL 2 are populated. Without HWA only WebGL 1 is populated and WebGL 2 gives the error. So I think there's something wrong in our port.

Comment 4

[Richard Marti (:Paenglab)]

Do you change HWA (layers.acceleration.disabled) through the GUI or about:config? If through GUI, do we something wrong here:
https://dxr.mozilla.org/comm-central/source/mail/components/preferences/advanced.js#433
to how FX does
https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/advanced.js#233

Comment 5

[Jorg K (CEST = GMT+2)]

At first I used the preferences individually and then I used the GUI since this is what users will do.

In FF, HWA off means:
gfx.direct2d.disabled = true
layers.acceleration.disabled = true

I checked that both are true in TB and WebGL 1 still shows an error.

Comment 6

[Jorg K (CEST = GMT+2)]

I think we're done here. We understand that the WebGL 2 information doesn't work with no HWA and that the throw is expected:
https://dxr.mozilla.org/mozilla-central/rev/a180b976c165b6cd174d24bbb77941919cdc53cb/toolkit/modules/Troubleshoot.jsm#451

We also understand that due to some missing configuration the WebLG 1 information wasn't displayed properly when porting the "about support" code to Thunderbird.