Closed
Bug 1340869
Opened 7 years ago
Closed 7 years ago
Crash in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::RecordTelemetryProbes
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
People
(Reporter: calixte, Assigned: smaug)
References
(Blocks 1 open bug)
Details
(Keywords: crash, Whiteboard: [clouseau])
Crash Data
Attachments
(1 file)
953 bytes,
patch
|
stone
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-598aec95-cc5f-4325-994c-edffc2170218. ============================================================= There are 3 crashes on nightly 54 with buildid 20170218030212. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1339135. [1] https://hg.mozilla.org/mozilla-central/rev?node=05a99b44e42436a163843a941cf9c8573f93d991
Flags: needinfo?(bugs)
Assignee | ||
Comment 1•7 years ago
|
||
Ok, we need similar null check as in https://hg.mozilla.org/mozilla-central/annotate/d11c29c1db3a/layout/base/nsRefreshDriver.cpp#l644
Flags: needinfo?(bugs)
Assignee | ||
Comment 2•7 years ago
|
||
Assignee: nobody → bugs
Attachment #8838935 -
Flags: review?(afarre)
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8838935 [details] [diff] [review] telemetry_crash.diff Perhaps stone gets to this sooner.
Attachment #8838935 -
Flags: review?(sshih)
Comment 4•7 years ago
|
||
Comment on attachment 8838935 [details] [diff] [review] telemetry_crash.diff LGTM. Thanks.
Attachment #8838935 -
Flags: review?(sshih) → review+
Assignee | ||
Updated•7 years ago
|
Attachment #8838935 -
Flags: review?(afarre)
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce3e5778328 crash @ RefreshDriverVsyncObserver::RecordTelemetryProbes, r=stone
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1ce3e5778328
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [clouseau]
You need to log in
before you can comment on or make changes to this bug.
Description
•