1340874 - Figure out a way to skip top level "wyciwyg" SHEntries when collecting session store data

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect, P3)

Description

[Jan Henning [:JanH]]

The session store code both on desktop and on Android skips collecting "wyciwyg" subframe data (https://dxr.mozilla.org/mozilla-central/rev/698de2db1b16a5ef3c6a39f0f72885e69aee4022/browser/components/sessionstore/SessionHistory.jsm#254 and https://dxr.mozilla.org/mozilla-central/rev/698de2db1b16a5ef3c6a39f0f72885e69aee4022/mobile/android/components/SessionStore.js#1308).

However it seems that under some circumstances we can encounter top-level "wyciwyg" SHEntries as well. For Fennec, we started skipping them when collecting session history data in bug 841151, however this was never ported over to Desktop as well.

Since I want to switch Fennec over to use SessionHistory.jsm (bug 1340828) so we don't have to keep maintaining to copies of the session history (de)serialisation code, I'd like to finally port this over to the Desktop code as well, however as far as I can see, the introduction of partial session histories has complicated things, because skipping entries locally looks like it might get things (toIdx/fromIdx) out of sync relative to the global history index when partial session history is involved.

Since Fennec doesn't really handle GroupedSHistory at the moment anyway, I'll leave SessionHistory.jsm as it is for the time being and continue including the bug 841151 code for Fennec only, however when we start properly implementing GroupedSHistory support on Android, we should fix this as well.

Comment 1

[Jan Henning [:JanH]]

Bug 1489308 apparently removes the need for wyciwyg URLs (see https://phabricator.services.mozilla.com/D17327), which is probably the nicest way of solving this problem.