1340914 - after shader editor refresh nothing is displayed anymore

Status: RESOLVED WONTFIX

(DevTools Graveyard :: WebGL Shader Editor, defect)

Description

[Trass3r]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.88 Safari/537.36 Vivaldi/1.8.755.3

Steps to reproduce:

http://demo.marpi.pl/archan/black_rain/
the demo works normally, scene and raindrops are shown
open shader editor
reload to enable the editor


Actual results:

just black screen and the enter button


Expected results:

scene is displayed correctly

Comment 1

[Loic]

Regression range:
Last good revision: 33c0181c4a25 (2014-10-20)
First bad revision: 29fbfc1b31aa (2014-10-21)
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=33c0181c4a25&tochange=29fbfc1b31aa

alice, any idea about the regressing bug?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=acce1a807efb&tochange=2681f9b134c2



The following error is shown on bad build:
"Unhandled promise rejection" Error: Permission denied to access property 'apply'
Stack trace:
createUniform@http://demo.marpi.pl/archan/black_rain/js/index.js:12683:3
createUniform@http://demo.marpi.pl/archan/black_rain/js/index.js:11571:5
init@http://demo.marpi.pl/archan/black_rain/js/index.js:12032:5
RainRenderer@http://demo.marpi.pl/archan/black_rain/js/index.js:12005:3
init@http://demo.marpi.pl/archan/black_rain/js/index.js:11725:14
loadTextures/<@http://demo.marpi.pl/archan/black_rain/js/index.js:11702:5
initIndex/<[150]</notify/</run@http://demo.marpi.pl/archan/black_rain/js/index.js:2706:39
initIndex/<[150]</notify/<@http://demo.marpi.pl/archan/black_rain/js/index.js:2717:28
initIndex/<[49]</flush@http://demo.marpi.pl/archan/black_rain/js/index.js:969:5
 index.js:2729

Comment 3

[Julien Cristau [:jcristau]]

Too late for firefox 52, mass-wontfix.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

victor,  is this on your radar? Looks like this hasn't worked since 2014 so maybe it's just general backlog.

Comment 5

[Victor Porof [:vporof][:vp]]

Not on my radar.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Use Cu.exportFunction so that content can access Function properties

Apply this patch on top of a patch from bug 1342237.

Comment 7

[Masatoshi Kimura [:emk]]

Comment on attachment 9031617 [details] [diff] [review]
Use Cu.exportFunction so that content can access Function properties

Shader Editor will be removed soon. (bug 1342237)