Closed Bug 1340923 Opened 3 years ago Closed 3 years ago

Replace remaining in-tree consumer of non-standard Iterator() with Object.{values,entries} in devtools/

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

remainder of bug 1292998
Telemetry.prototype.telemetryInfo is an object, so we can use Object.entries instead.
Attachment #8839033 - Flags: review?(jryans)
Comment on attachment 8839033 [details] [diff] [review]
Remove remaining Iteartor consumer from devtools/.

Review of attachment 8839033 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the cleanup!

Is this another one to fix?

http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/test-bug-632347-iterators-generators.html#23
Attachment #8839033 - Flags: review?(jryans) → review+
> Remove remaining Iteartor consumer from devtools/.

I happened to notice a typo in this description when the bugmail went by...
it should be "Iterator".
Thank you for reviewing :)

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Is this another one to fix?
> 
> http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/
> test-bug-632347-iterators-generators.html#23

it looks like testing the Iterator itself in devtools, so I'll leave it until we actually remove Iterator from JS engine (that won't happen near future)
before that it should be better to keep testing the feature.


(In reply to Tom Tromey :tromey from comment #3)
> > Remove remaining Iteartor consumer from devtools/.
> 
> I happened to notice a typo in this description when the bugmail went by...
> it should be "Iterator".

thanks :D
https://hg.mozilla.org/mozilla-central/rev/3ed5c0fa2f8d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.