Closed Bug 1340929 Opened 7 years ago Closed 7 years ago

Opening a link in a new tab scrolls the tab strip to the new tab on a tablet

Categories

(Firefox for Android Graveyard :: General, defect, P1)

defect

Tracking

(fennec53+, firefox51 unaffected, firefox52 unaffected, firefox53+ verified, firefox54+ verified)

VERIFIED FIXED
Firefox 54
Tracking Status
fennec 53+ ---
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 + verified
firefox54 + verified

People

(Reporter: twointofive, Assigned: twointofive)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is a tablet bug.

STR:
1) Open a bunch of tabs on the tab strip (more than will fit on screen).
2) Select the first tab and load a page with a url.
3) Long click on the url and select "Open in New Tab".

ER: The tab strip doesn't move; you never see the new tab in the tab strip because it gets added to the end, which isn't currently visible.

AR: The tab strip scrolls to the new tab (which is not the selected tab).
I expect this was regressed by bug 1317446, but I don't have a tablet to check 51 or 52, and when I click on the "Download" link on a tablet emulator at https://www.mozilla.org/en-US/firefox/channel/android nothing happens.  (Hmm, that button opens the Play Store on my actual phone, which doesn't help for what I wanted to do.)
Thanks Jan.
[Tracking Requested - why for this release]: Regression in Fx 53
tracking-fennec: --- → ?
tracking-fennec: ? → 53+
Priority: -- → P1
Tracking 53/54 for this new tablet regression.
Comment on attachment 8840525 [details]
Bug 1340929 - Don't scroll to a new tab opened from a link.

https://reviewboard.mozilla.org/r/114976/#review117746
Attachment #8840525 - Flags: review?(s.kaspari) → review+
Pushed by twointofive@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a62afb4f179
Don't scroll to a new tab opened from a link. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/8a62afb4f179
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8840525 [details]
Bug 1340929 - Don't scroll to a new tab opened from a link.

Approval Request Comment
[Feature/Bug causing the regression]:bug 1317446
[User impact if declined]: On a tablet with many tabs open, when you open a link in a new tab the tab strip will scroll to the new tab instead of staying on the currently selected tab.
[Is this code covered by automated tests?]: No. (The patch includes a test for this, but we don't run automated tests on tablets.)
[Has the fix been verified in Nightly?]: Yes, I verified the fix in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: STR are in comment 0.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low risk.
[Why is the change risky/not risky?]: This patch stops updating the scroll position when we add a tab and instead only updates the position when a tab is selected - that was the old correct behavior which I regressed when I wrote bug 1317446.
[String changes made/needed]: None.
Attachment #8840525 - Flags: approval-mozilla-aurora?
Comment on attachment 8840525 [details]
Bug 1340929 - Don't scroll to a new tab opened from a link.

Recent regression, specific to tablets, let's uplift the fix to aurora 53.
Attachment #8840525 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified on Aurora 54 and Beta 53.0b2 on Lenovo Yoga Tablet 2 (Android 4.4.2) and the issue is fixed.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.