Opening a link in a new tab scrolls the tab strip to the new tab on a tablet

VERIFIED FIXED in Firefox 53

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
10 months ago
9 months ago

People

(Reporter: Tom Klein, Assigned: Tom Klein)

Tracking

({regression})

Trunk
Firefox 54
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(fennec53+, firefox51 unaffected, firefox52 unaffected, firefox53+ verified, firefox54+ verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
This is a tablet bug.

STR:
1) Open a bunch of tabs on the tab strip (more than will fit on screen).
2) Select the first tab and load a page with a url.
3) Long click on the url and select "Open in New Tab".

ER: The tab strip doesn't move; you never see the new tab in the tab strip because it gets added to the end, which isn't currently visible.

AR: The tab strip scrolls to the new tab (which is not the selected tab).
(Assignee)

Comment 1

10 months ago
I expect this was regressed by bug 1317446, but I don't have a tablet to check 51 or 52, and when I click on the "Download" link on a tablet emulator at https://www.mozilla.org/en-US/firefox/channel/android nothing happens.  (Hmm, that button opens the Play Store on my actual phone, which doesn't help for what I wanted to do.)
status-firefox53: --- → affected

Comment 2

10 months ago
https://ftp.mozilla.org/pub/mobile/releases/ for Release + Beta,
https://ftp.mozilla.org/pub/mobile/nightly/ for Aurora + Nightly
(Assignee)

Comment 3

10 months ago
Thanks Jan.
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
[Tracking Requested - why for this release]: Regression in Fx 53
tracking-fennec: --- → ?
tracking-firefox53: --- → ?
tracking-firefox54: --- → ?
Keywords: regressionwindow-wanted
tracking-fennec: ? → 53+
Priority: -- → P1
Regression window:

Last good build: 2016-12-19
First bad build: 2016-12-20

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=863c2b61bd27bb6099104933134d3be7c052551a&tochange=567894f026558e6dada617a3998f29aed06ac7d8
Keywords: regressionwindow-wanted
Tracking 53/54 for this new tablet regression.
tracking-firefox53: ? → +
tracking-firefox54: ? → +
Comment hidden (mozreview-request)

Comment 8

10 months ago
mozreview-review
Comment on attachment 8840525 [details]
Bug 1340929 - Don't scroll to a new tab opened from a link.

https://reviewboard.mozilla.org/r/114976/#review117746
Attachment #8840525 - Flags: review?(s.kaspari) → review+

Comment 9

10 months ago
Pushed by twointofive@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8a62afb4f179
Don't scroll to a new tab opened from a link. r=sebastian

Comment 10

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a62afb4f179
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(Assignee)

Comment 11

10 months ago
Comment on attachment 8840525 [details]
Bug 1340929 - Don't scroll to a new tab opened from a link.

Approval Request Comment
[Feature/Bug causing the regression]:bug 1317446
[User impact if declined]: On a tablet with many tabs open, when you open a link in a new tab the tab strip will scroll to the new tab instead of staying on the currently selected tab.
[Is this code covered by automated tests?]: No. (The patch includes a test for this, but we don't run automated tests on tablets.)
[Has the fix been verified in Nightly?]: Yes, I verified the fix in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: STR are in comment 0.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low risk.
[Why is the change risky/not risky?]: This patch stops updating the scroll position when we add a tab and instead only updates the position when a tab is selected - that was the old correct behavior which I regressed when I wrote bug 1317446.
[String changes made/needed]: None.
Attachment #8840525 - Flags: approval-mozilla-aurora?
Comment on attachment 8840525 [details]
Bug 1340929 - Don't scroll to a new tab opened from a link.

Recent regression, specific to tablets, let's uplift the fix to aurora 53.
Attachment #8840525 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 13

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ccfe0752e919
status-firefox53: affected → fixed
Flags: in-testsuite+

Comment 14

9 months ago
Verified on Aurora 54 and Beta 53.0b2 on Lenovo Yoga Tablet 2 (Android 4.4.2) and the issue is fixed.
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.